Coverage comment experiment #3150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that all of the comments are being sent to FoundationDB#3147, the change which introduced `pull_request_comments.yml`, which I think is a mistake. To avoid that, this tries to use a job within the PR
6c45069 to
19b28a2
Compare
MMcM
reviewed
Feb 13, 2025
| permissions: | ||
| checks: write | ||
| contents: read | ||
| pull-requests: write |
There was a problem hiding this comment.
I don't think that this will work: pull_request workflows have their permissions always limited, since they are running code from the PR itself. (There is pull_request_target, but the protection is intentional.)
If the pull_request triggering the workflow_run isn't working properly, then we could write the PR number into an artifact and read from there in the workflow_run workflow, passing the number to the comment action. See https://github.com/Madrapps/jacoco-report/blob/main/src/action.ts#L92-L101 for how it tries to figure it out -- which is evidently not working -- and the available override.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that all of the comments are being sent to #3147, the change which introduced
pull_request_comments.yml, which I think is a mistake. To avoid that, this tries to use a job within the PR