Publish a consolidated JaCoCo report from multiple subprojects and split test jobs #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add another top-level report task to combine them.
* `pull_request` test jobs also publish JaCoCo `.exec` artifacts. * `pull_request_coverage` runs in head branch and generated combined JaCoCo report from those. * `pull_request_comment` runs in target branch and adds comment form that.
MMcM
commented
Feb 13, 2025
Comment on lines
+40
to
+57
| - name: Checkout sources | ||
| uses: actions/checkout@v4.2.2 | ||
| - name: Setup Base Environment | ||
| uses: ./actions/setup-base-env | ||
| - name: Setup FDB | ||
| uses: ./actions/setup-fdb | ||
| - name: Run Gradle Test | ||
| uses: ./actions/gradle-test | ||
| with: | ||
| gradle_command: :fdb-record-layer-core:test :fdb-record-layer-core:destructiveTest | ||
| gradle_args: -PreleaseBuild=false -PpublishBuild=false | ||
| - name: Publish Test Reports | ||
| if: always() | ||
| uses: actions/upload-artifact@v4.6.0 | ||
| with: | ||
| name: core-test-reports | ||
| path: | | ||
| test-reports/fdb-record-layer-core/ |
There was a problem hiding this comment.
Adjusting indentation to match the rest of the file.
alecgrieser
approved these changes
Feb 13, 2025
|
|
|
alecgrieser
added a commit
to alecgrieser/fdb-record-layer
that referenced
this pull request
Feb 13, 2025
I noticed that all of the comments are being sent to FoundationDB#3147, the change which introduced `pull_request_comments.yml`, which I think is a mistake. To avoid that, this tries to use a job within the PR
alecgrieser
added a commit
to alecgrieser/fdb-record-layer
that referenced
this pull request
Feb 13, 2025
I noticed that all of the comments are being sent to FoundationDB#3147, the change which introduced `pull_request_comments.yml`, which I think is a mistake. To avoid that, this tries to use a job within the PR
|
1 similar comment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.execfiles out of both-testjobs.pull-requestworkflow job that downloads those artifacts and generates a report.workflow_runworkflow (needed to getpull_requestcommenting access) to use that report.