-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation notice urllib3[secure] #473
Conversation
Signed-off-by: V24 <55334829+umarfarouk98@users.noreply.github.com>
Signed-off-by: V24 <55334829+umarfarouk98@users.noreply.github.com>
Signed-off-by: V24 <55334829+umarfarouk98@users.noreply.github.com>
Pull Request Test Coverage Report for Build 2833305627
💛 - Coveralls |
Thanks for the notice, @umarfarouk98. The .txt requirement files are generated with pip-tools. I will study what the necessary changes in .in files would need to be. First result: We are importing urllib3 via requests, which is needed by tldextract.
It seems none of these hard-code a version requirement anywhere, so I believe there is not much we can do here, other than hard-code urllib3 in the .in files ourselves, and see if that works. But ultimately, it seems our packaging pipeline would pick up on later urllib3 versions removing the [secure] part, by itself. Good to see that this PR passes our test pipeline already. |
You may want to retain the dependencies that were originally installed via urllib3[secure] like `idna, pyOpenSSL, certifi, etc. |
|
Thanks, all. I see the Selenium people already merged that issue, so in one of our next releases (we release every 4-6 weeks, roughly, and usually run pip-compile after each release), this will be okay. I'm merging this to honor your help. |
Description
pyOpenSSL and urllib3[secure] are deprecated in the upcoming release (1.26.12)
urllib3/urllib3#2680