Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on Selenium #106

Closed
nhoening opened this issue Aug 21, 2022 · 3 comments · Fixed by #107
Closed

Drop dependency on Selenium #106

nhoening opened this issue Aug 21, 2022 · 3 comments · Fixed by #107
Assignees
Milestone

Comments

@nhoening
Copy link
Contributor

It seems to me that selenium is only needed if the user wants to save a chart as PNG?

As it is quite a large dependency, I'd advocate we remove it from dependencies. Visualisations are not a core feature of this library. We can instead document somehow that it is to be installed for saving charts (e.g. in docs/viz.md and in the main ReadMe, where we describe making visualisations).

See also this ticket, where that dependency created effort.

@nhoening nhoening added this to the 1.11.6 milestone Aug 21, 2022
@Flix6x
Copy link
Collaborator

Flix6x commented Aug 21, 2022

I thought about listing it as an optional dependency, but I'm not sure yet how that works. I have a second use case for such a solution, so this may be a good time to find out. pyproject.toml?

@nhoening
Copy link
Contributor Author

I know nothing about that. Does that lead to a parameter or option when describing timely beliefs as a dependency, e.g. [plots]?

@Flix6x Flix6x self-assigned this Aug 22, 2022
@create-issue-branch
Copy link

Branch issue-106-Drop_dependency_on_Selenium created!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants