-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't show duplicate deployed releases (#63). add release name to the name output for helm (#67) #69
Conversation
Co-Authored-By: Andrew Suderman <andrew@sudermanjr.com>
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 80.68% 77.90% -2.79%
==========================================
Files 6 6
Lines 321 353 +32
==========================================
+ Hits 259 275 +16
- Misses 43 51 +8
- Partials 19 27 +8
Continue to review full report at Codecov.
|
Hmm, I'm not sure how it calculated coverage went down by 3%. All the new things should be getting hit by the current tests. I can look tomorrow. |
Do you think it's worth adding a bunch of tests just to cover |
Depends on whether you think those errors are important to test. If you don't, then I'm fine with the drop. Some of the marshal/unmarshal errors might be good to test, but I suspect it would be difficult to do and unlikely to hit that error case. |
I think this is as good as it's going to get for now. We can definitely revisit this package in a separate PR and probably make it a bit more DRY which would help with test coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a plan. Thanks!
also adds release name to output for helm
fixes #63
fixes #67