Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit output when detect-helm is used #31

Closed
lucasreed opened this issue Apr 8, 2020 · 3 comments
Closed

Revisit output when detect-helm is used #31

lucasreed opened this issue Apr 8, 2020 · 3 comments
Labels
enhancement Adding additional functionality or improvements good first issue Good for newcomers

Comments

@lucasreed
Copy link
Contributor

Thoughts:

  • It would be useful if the chart name is a column in the output
  • When looking at a few clusters using the detect-helm feature, I realized it becomes harder to identify things without the namespace in the output. Also since the same chart could be launched into different namespaces, having the namespace along with the chart name will reduce a couple investigation steps after running pluto.

Those couple things being said. I propose our output change to something like this only when detect-helm is used:

NAMESPACE\t CHART\t KIND\t VERSION\t DEPRECATED\t RESOURCE NAME

Open to thoughts on this. I could also see us implementing a -o wide output option for more fields. Perhaps having TEMPLATE with a value of the template file within the chart.

@lucasreed lucasreed changed the title Revisit output when detect-helm is used Revisit output when detect-helm is used Apr 8, 2020
@sudermanjr
Copy link
Member

I definitely like the -o wide idea to add more output. Then that additional output could be customized to each type of detection.

@sudermanjr sudermanjr added enhancement Adding additional functionality or improvements good first issue Good for newcomers labels Apr 14, 2020
@sudermanjr
Copy link
Member

We also discussed potentially changing the NAME to be filepath/filename and release-name/resource-name for the different checks.

@sudermanjr
Copy link
Member

Between #76 and in #69 and think we can call this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants