Cleanup improvements #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…object-based approach using cheerio. This change is for better readability and maintainability of the code and does not noticeably impact the speed of the task.
…d mapped to uniqued IDs. Unreferenced IDs are removed in order to save space.
…nup is done on elements inside the <defs> element. Changed option 'cleanup'; it now accepts an array of attributes. For backwards compatibility cleanup === true equals ['style']. The attributes in the array are removed from all elements.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option 'cleanupdefs' (default: false); when set to false no cleanup is done on elements inside the <defs> element. This can be useful when one does not want to remove style-attributes for elements inside <defs> elements. For example, on usingdef.svg (blob/master/test/fixtures/usingdef.svg) one may not want to remove the style attribute (style="stop-color:rgb(255,255,0);stop-opacity:1") which sets the style for the linearGradient. For reasons mentioned in #37, one may want to remove all other style attributes.
Changed option 'cleanup'; it now accepts an array of attributes. For backwards compatibility cleanup === true equals ['style']. The attributes in the array are removed from all elements. This can be useful for example when one want to set the fill of a drawing using CSS.