-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the way ID are collected #40
Conversation
…d mapped to uniqued IDs. Unreferenced IDs are removed in order to save space.
I just figured the md5 function is actually called more often now. I will fix this tomorrow. |
Style changes (code and comments)
…d mapped to uniqued IDs. Unreferenced IDs are removed in order to save space.
I tried the rebasing as suggested in #42. Now this branch seems to consist of only the commits related to this PR. For some reason I ended up with two times the 'Minor speed improvement...' commit. What I did was:
Should I clean this up more? By rebasing / squashing commits into a single commit? |
Could you take another look at this PR? I'm unclear on how to improve this one. |
Changed the way ID are collected
Finally got some time to merge all this in thanks for this! 🎆 Would you mind writing a small list of all changes you did feature releated? |
Thanks for merging the PR's! I'll try to make possible future PR's less cluttered. The first PR (#39) was solely about style changes, so I don't need to comment on that. Changes / new features:
|
@Frank3K Thanks 👏 released in |
All referenced IDs are collected and mapped to unique IDs. Unreferenced IDs are removed in order to save space and clutter. Furthermore, the md5()-function is only called when really necessary which leads to (micro) time optimizations.