Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the way ID are collected #40

Merged
merged 8 commits into from
Jul 24, 2014
Merged

Conversation

Frank3K
Copy link
Contributor

@Frank3K Frank3K commented Jun 28, 2014

All referenced IDs are collected and mapped to unique IDs. Unreferenced IDs are removed in order to save space and clutter. Furthermore, the md5()-function is only called when really necessary which leads to (micro) time optimizations.

Frank3K added 2 commits June 28, 2014 21:27
…d mapped to uniqued IDs. Unreferenced IDs are removed in order to save space.
@Frank3K Frank3K changed the title Changed the way ID are collected. Changed the way ID are collected Jun 28, 2014
@Frank3K
Copy link
Contributor Author

Frank3K commented Jun 30, 2014

I just figured the md5 function is actually called more often now. I will fix this tomorrow.

Style changes (code and comments)
@FWeinb FWeinb mentioned this pull request Jul 1, 2014
@Frank3K
Copy link
Contributor Author

Frank3K commented Jul 1, 2014

I tried the rebasing as suggested in #42. Now this branch seems to consist of only the commits related to this PR. For some reason I ended up with two times the 'Minor speed improvement...' commit.

What I did was:

  • git checkout id-references (i.e. the branch we need here)
  • git pull --rebase upstream master (where upstream is the clone URL of your repository)
  • git pull (otherwise it did not push)
  • git push

Should I clean this up more? By rebasing / squashing commits into a single commit?

@Frank3K
Copy link
Contributor Author

Frank3K commented Jul 23, 2014

Could you take another look at this PR? I'm unclear on how to improve this one.

FWeinb added a commit that referenced this pull request Jul 24, 2014
Changed the way ID are collected
@FWeinb FWeinb merged commit 904ff1e into FWeinb:master Jul 24, 2014
@FWeinb
Copy link
Owner

FWeinb commented Jul 24, 2014

Finally got some time to merge all this in thanks for this! 🎆

Would you mind writing a small list of all changes you did feature releated?

@Frank3K Frank3K deleted the id-references branch July 26, 2014 14:24
@Frank3K
Copy link
Contributor Author

Frank3K commented Jul 26, 2014

Thanks for merging the PR's! I'll try to make possible future PR's less cluttered.

The first PR (#39) was solely about style changes, so I don't need to comment on that.

Changes / new features:

  • Changed the way ID are collected; unreferenced IDs are removed now in order to save space. (Changed the way ID are collected #40)
  • Changed the behavior of the 'cleanup'-option (introduced in 0.2.6). Apart from true / false, the value of this property can now be an array of attributes. All attributes in the array are removed from all elements in the SVG. (Cleanup improvements #41)
  • Added an option 'cleanupdefs' (default: false). When set to false, no cleanup is performed on the <defs> element. (Cleanup improvements #41)
  • Empty g elements are removed since they have no effect in a document. (Remove empty g elements #42)

@FWeinb
Copy link
Owner

FWeinb commented Jul 26, 2014

@Frank3K Thanks 👏 released in 0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants