-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove policy default rooms when policy member is removed from policy #8684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @danieldoglas in version: 1.1.56-0 🚀
|
@francoisl We retested the PR and it seems to be still partially failing. Room doesn't disappear while you are logged in. However, It disappears after you log out and log back in. PR_33568.mp4 |
It appears that applause.expensifail.com is not in the |
🚀 Deployed to production by @francoisl in version: 1.1.56-0 🚀
|
cc @TomatoToaster @Gonals
Details
When a policy member is removed from a policy, make sure we get rid of the policy rooms they were a part of, since they don't have access anymore. This is the Front-End side of a two part PR. We'll listen to the pusher policy channel for a notification when a policy member is removed and take the appropriate actions when that happens.
Fixed Issues
$ #8470
Tests / QA Steps
(Note: This can only be tested once https://github.com/Expensify/Web-Expensify/pull/33568 is merged and deployed to prod)
Manage members
tab of the workspace, invite user 2PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)