Web - Default rooms are showing for removed users

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing PR: #8684

Action Performed:

1. Create a workspace with user 1
2. Go to the Manage members tab of the workspace, invite user 2
3. Login to user 2 via incognito window, verify that there is an #announce chat room shown in LHN
4. Navigate back to user 1 session, remove user 2 from the policy
5. Navigate back to user 2 session

Expected Result:

Make sure you cannot see any default rooms from the workspace (verify the #announce chat room is no longer shown in the LHN

Actual Result:

Announce default rooms from the workspace is shown in the LHN. It's disappeared only logout > login user.

Workaround:

Unknow

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.56

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): 1. applausetester+042022@applause.expensifail.com
2. applausetester+042022cx@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5541479_resign_in.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Luke9389]

@kbecciv, I've noticed that it's hard for me to parse the issues you create.
Would you try to focus on more clear titles? For example, this one could be Default rooms are showing for removed users, or something like that. Know that you can always provide more detail in the description, so don't feel like you need to jam it all into the title.

Also, did you reload the page after step 5 of the Actions Performed?

[kbecciv]

@Luke9389 Sorry for confusion, I will keep the titles simple and clear as you mention above. Yes, tester reloaded the page after step 5.

Not.deleted.mp4

[Luke9389]

Can you retest this now that this PR is live? https://github.com/Expensify/Web-Expensify/pull/33568

[Luke9389]

@kbecciv bump on my last comment

[kbecciv]

@Luke9389 Sorry, I missed your message.
Retested with latest build 1.1.78-1, default rooms are disappears after log out and log in again. Video attached

Recording.865.mp4

[Luke9389]

Huh, that looks like a video about 2FA... 😅

[kbecciv]

@Luke9389 I'm sorry, updated correct video.

[Luke9389]

Ok cool. Thanks so much! That video really covers all the questions I had.

@yuwenmemon @TomatoToaster
It looks like you guys worked on this issue here: https://github.com/Expensify/Web-Expensify/pull/33568

Do you think I should make this external and have a contributor look at it, or do you want to take a peek and see if you can spot the issue?

[TomatoToaster]

I think this makes sense to keep as internal. I'm not sure myself, why this isn't working, but these lines of code should make it so that the user's client is subscribed to the policy member being removed and then should remove those default rooms. My hunch is that defaultRoomChatIDs isn't being set properly in the Pusher event, so this might require an internal change.

[Luke9389]

I'll investigate this further this week.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[Luke9389]

looks like this'll end up being fixed.

[Luke9389]

Waiting on reproduction

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[Luke9389]

noice!

[mvtglobally]

Issue not reproducible during KI retests. (Third week) Closing