Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim Room title on the report details page #7223

Merged
merged 5 commits into from
Jan 28, 2022
Merged

Trim Room title on the report details page #7223

merged 5 commits into from
Jan 28, 2022

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jan 14, 2022 •
edited
Loading

Details

Fixed Issues

$ #7181

Tests | QA Steps

  1. Go to staging.new.expensify.com
  2. log in expensifail account
  3. Click FAB + > New room
  4. You need to enter long room name
  5. Select any Workspace
  6. Tap Create
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image
image

iOS

image

Android

image

@parasharrajat parasharrajat marked this pull request as ready for review January 28, 2022 05:19
@parasharrajat parasharrajat requested a review from a team as a code owner January 28, 2022 05:19
@botify botify requested a review from iwiznia January 28, 2022 05:19
@MelvinBot MelvinBot removed the request for review from a team January 28, 2022 05:19
@iwiznia iwiznia merged commit c8d47a0 into Expensify:main Jan 28, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Feb 1, 2022
Closed
46 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to staging by @iwiznia in version: 1.1.33-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify botify mentioned this pull request Feb 2, 2022
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Feb 2, 2022

🚀 Deployed to production by @sketchydroide in version: 1.1.34-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwiznia iwiznia iwiznia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @iwiznia