[HOLD for payment 2022-02-09] Room - Settings - The room name has unlimited characters

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com
2. log in expensifail account
3. Click FAB + > New room
   3.You need to enter long room name
4. Select any Workspace
5. Tap Create

Expected Result:

The room name should have limited characters

Actual Result:

The room name has unlimited characters

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.29.1

Reproducible in staging?: Yes

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[flodnv]

Labelled DeployBlocker due to Reproducible in production?: No

[MelvinBot]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mvtglobally]

@flodnv feature is not available in Prod yet, so we are not able to check.that's why teat didn't add Blocker label

[flodnv]

Ahhh ok 👍 I asked internally to check if it should be a blocker or not, I am not sure, but I think yes.

[parasharrajat]

Proposal

I can think of multiple tasks to do here.

1. First we need to restrict the length of chars.
2. Second we need to Trim the name on the Settings page with an ellipsis.

Can someone confirm what is the scope of this issue?

Second we need to Trim the name on the Settings page with an ellipsis.

1. For this, we need to add a wrapper View to

   App/src/pages/ReportDetailsPage.js

   Line 142 in a4d72f7

   <DisplayNames

   .

with Styles.w100 and styles.alignSelfCenter.
2. Add Styles.w100 to

App/src/pages/ReportDetailsPage.js

Line 141 in a4d72f7

<View style={styles.reportDetailsRoomInfo}>

First we need to restrict the length of chars.

This is already done in

App/src/pages/workspace/WorkspaceNewRoomPage.js

Line 117 in a4d72f7

<RoomNameInput

.

App/src/components/RoomNameInput.js

Line 99 in 4123f1a

.substring(0, CONST.REPORT.MAX_ROOM_NAME_LENGTH)

[stephanieelliott]

Posted to Upwork: https://www.upwork.com/jobs/~01eecb1a8f50499aab

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @iwiznia (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[iwiznia]

Can someone confirm what is the scope of this issue?

Both of those sound reasonable to me.

First we need to restrict the length of chars.
This is already done in

I don't see anything related to max chars there

[parasharrajat]

Oops, tagged the wrong line.

App/src/components/RoomNameInput.js

Line 99 in 4123f1a

.substring(0, CONST.REPORT.MAX_ROOM_NAME_LENGTH)

[iwiznia]

Oh, if we have that, why is this bug present? 😕

[parasharrajat]

Length is set to 80 char which is pretty big and thus we need to clip the text in the UI with ellipsis in the Side-modal so that it does not overflow.

[iwiznia]

oh ok. Proposal looks good then 👍

[parasharrajat]

Do we want to reduce the number of chars from the Room name?

[stephanieelliott]

I invited you to the job on Upwork @parasharrajat, please accept when you get a chance.

[iwiznia]

Do we want to reduce the number of chars from the Room name?

To what number?

[parasharrajat]

May be 50 from 80...

[iwiznia]

I am fine with 50 honestly, but not sure what's best... maybe let's ask in the open source channel what people think?

[parasharrajat]

https://expensify.slack.com/archives/C01GTK53T8Q/p1642444018076500

[parasharrajat]

Update: Facing a strange issue. Trying to see what has changed.

[parasharrajat]

Didn't find any solution that works on each platform yet. I am looking to find a universal design approach.

[parasharrajat]

I will get back to it today.

[parasharrajat]

PR is ready for review.

[stephanieelliott]

PR is undergoing QA

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.34-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Trim Room title on the report details page #7223

If no regressions arise, payment will be issued on 2022-02-09. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[stephanieelliott]

Paid up!