-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travel - Enable trip room renaming #55936
Travel - Enable trip room renaming #55936
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-02-01.at.12.10.17.AM.movAndroid: mWeb ChromeScreen.Recording.2025-01-31.at.11.53.27.PM.moviOS: NativeScreen.Recording.2025-02-01.at.12.05.05.AM.moviOS: mWeb SafariScreen.Recording.2025-01-31.at.11.48.05.PM.movMacOS: Chrome / SafariScreen.Recording.2025-01-31.at.11.39.34.PM.movMacOS: DesktopScreen.Recording.2025-01-31.at.11.57.16.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well, just one minor comment
const validate = useCallback( | ||
(values: FormOnyxValues<typeof ONYXKEYS.FORMS.NEW_CHAT_NAME_FORM>): Errors => { | ||
const errors: Errors = {}; | ||
if (!isValidReportName(values[INPUT_IDS.NEW_CHAT_NAME] ?? '')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also validate the case for empty room name? The group chat has a default name that is why we let it be empty, but trip rooms don't I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one, changed 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.95-0 🚀
|
@blazejkustra QA encountered with issue #54567 on all platforms |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀
|
const [avatarFile, setAvatarFile] = useState<File | CustomRNImageManipulatorResult | undefined>(); | ||
const {translate} = useLocalize(); | ||
const styles = useThemeStyles(); | ||
const personalData = useCurrentUserPersonalDetails(); | ||
const [newGroupDraft] = useOnyx(ONYXKEYS.NEW_GROUP_CHAT_DRAFT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came from this issue
Looks like using useOnyx instead withOnyx called this issue
To fix this we updated a condition here to call readFileAsync after the onyx value is loaded completely
Explanation of Change
@rlinoz added new command for renaming trip rooms on the backend. This is FE part of this so that users can rename trip rooms.
Fixed Issues
$ #54539
PROPOSAL: N/A
Tests
Precondition - book a travel from olddot within a workspace that doesn't support chats (you can check it in the console)
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Check web and ios
Android: mWeb Chrome
Check web and ios
iOS: Native
ios.mp4
iOS: mWeb Safari
Check web and ios
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
Check web and ios