[Due for payment 2025-02-18] Trip - Room name field does not include left parenthesis of the trip room name

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.78-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #52823
Email or phone of affected tester (no customers): applausetester+0948501@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11
App Component: Other

Action Performed:

Precondition:

• Create a trip with steps from this PR [vip-travel] Create Trip Details Screen #52823

1. Go to staging.new.expensify.com
2. Go to the trip room.
3. Click on the room header
4. Click Room name.

Expected Result:

Room name field should contain the complete room name.

Actual Result:

Room name field does not include the first character of the room name, which is the left parenthesis.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701758_1735042914890.bandicam_2024-12-24_20-18-38-084.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@laurenreidexpensify Eep! 4 days overdue now. Issues have feelings too...

[laurenreidexpensify]

I see latest version of staging is v9.0.79-4, so let's retest on that before moving forward

[melvin-bot]

@laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[laurenreidexpensify]

Waiting for retest

[CyberAndrii]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Trip - Room name field does not include left parenthesis of the trip room name

What is the root cause of that problem?

In code, the room name is assumed to always be prefixed with #. However, since trip rooms are not prefixed, the first character is removed instead of specifically removing #.

App/src/components/RoomNameInput/index.tsx

Line 57 in 1cfcfa4

value={value?.substring(1)} // Since the room name always starts with a prefix, we omit the first character to avoid displaying it twice.

What changes do you think we should make in order to solve the problem?

Either prefix trip room names with # or modify the code to remove the first character only if the name starts with #

-value={value?.substring(1)}
+value={value?.startsWith(CONST.POLICY.ROOM_PREFIX) ? value.substring(1) : value}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

A test to validate the value of TextInput with and without the # prefix.

[shubham1206agra]

@laurenreidexpensify Since contributors don't have access to trip rooms. Please assign this to me and @blazejkustra.

[laurenreidexpensify]

@blazejkustra pls comment on issue so I can assign you thanks

[melvin-bot]

@shubham1206agra @laurenreidexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[blazejkustra]

Sorry, I was OOO until today. Commenting for assignment @laurenreidexpensify

[blazejkustra]

I'm a bit confused, it seems like I can't edit the room name for my trips:

Screen.Recording.2025-01-07.at.12.21.01.mov

Could it be that something changed during last two weeks and now editing the name is disabled? @IuliiaHerets Could you retest this or provide more detailed steps? cc @laurenreidexpensify

[blazejkustra]

@IuliiaHerets Could you add me to that workspace and make me an admin? That could make it easier to debug. Here is my email: blazej.kustra+trav3@swmansion.com

[kavimuru]

Added you as a admin @blazejkustra

[blazejkustra]

Update: I have a draft PR.

This is an edge case that occurs only when reserving a trip within a workspace where chats are disabled. In this scenario, the trip room is treated as a chat rather than a thread (which is the usual behavior). Slack thread with more details

The approach I took was to simply disable the ability to edit the room name. By default, all Spotnana trips include a date in brackets at the beginning of the name, which violates the rule: "Room names can only include lowercase letters, numbers, and hyphens." Allowing this would require a significant refactor.

[stitesExpensify]

Chatted 1:1 with @blazejkustra , we think we might be able to just remove the restriction

[blazejkustra]

There’s one potential approach we could explore, but it would require some backend changes. While chats currently have the naming restriction described earlier (only allowing lowercase letters, numbers, and hyphens), group chats do not. If we reuse the group chat logic for trip rooms, we could potentially support this functionality without naming restrictions. Here is how it would work:

Screen.Recording.2025-01-09.at.15.11.01.mov

That said, there’s one blocker to this approach. Under the hood UpdateGroupChatName command is used. Currently it returns an error when attempting to use it for a trip room. Addressing this would require adjustments to how the backend handles trip room name updates (either new command or adjust the existing one)

cc @stitesExpensify @rlinoz

[shubham1206agra]

Yes, will review it today.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Travel - Enable trip room renaming #55936

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @shubham1206agra requires payment (Needs manual offer from BZ)

[melvin-bot]

@shubham1206agra @laurenreidexpensify @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[laurenreidexpensify]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[shubham1206agra]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: NA since this feature was implemented in this issue itself.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Book a travel from olddot within a workspace that doesn't support chats (you can check it in the console)

Policy.getCurrent().policy.isPolicyExpenseChatEnabled

Test:

1. Open the URL: https://staging.expensify.com/
2. Log in with an account
3. Click on Travel > Book or manage travel
4. Book a hotel can be any (On payment filter select: 'Pay at property')
5. After your booking is successful, go to NewDot App
6. Click on 'Reports'
7. Click the booked hotel report > Click on 'Submit' > Click on 'Send'
8. Open the chat of the booked hotel
9. Click on the room header
10. Verify that changing trip room name is working

Do we agree 👍 or 👎

[rlinoz]

I am not sure the pre condition is needed, but the test is good

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @blazejkustra is from an agency-contributor and not due payment
• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@laurenreidexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[laurenreidexpensify]

Job added to Upwork: https://www.upwork.com/jobs/~021891861354300781002 for payment @shubham1206agra pls apply

[laurenreidexpensify]

Contract sent to Shubham in Upwork

[laurenreidexpensify]

@shubham1206agra can you accept offer so we can release payment? Thanks

[melvin-bot]

@rlinoz, @stitesExpensify, @blazejkustra, @shubham1206agra, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[laurenreidexpensify]

@shubham1206agra bump thanks

[laurenreidexpensify]

Spoke to Shubnam about this, downgrading to monthly for now