[TS migration] Migrate 'UnlinkLogin' page to TypeScript #32966

VickyStash · 2023-12-13T13:51:41Z

Details

[TS migration] Migrate 'UnlinkLogin' page to TypeScript

Fixed Issues

$ #25171
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Log in to the app using account email A.
Go to Settings -> Profile
Tap on the Contact Method -> New contact method
Enter email address B and press Add.
A new contact method should appear in the list with a note, "Please verify this contact method." - you shouldn't verify it to test this ticket.
Go to the login screen (logout if you was logged in)
Try to login with email address B -> You should be navigated to the Welcome back view with Unlink button
Press Unlink button and wait for the link to be send to the email B.
Go to the email message with the link to unlink the account.
Copy the link address and replace https://new.expensify.com/ part with your dev app URL https://dev.new.expensify.com:8082/
Open the link you have now in the browser, you should see long loading - that's the screen we test - UnlinkLoginPage
After that you should be navigated to the login screen with a message 'Secondary login successfully unlinked!'

Note:
For mobile platform you can use deeplinks to open the URL, just run in the terminal
npx uri-scheme open new-expensify://ENDPOINT_FROM_MESSAGE --ios
or
npx uri-scheme open new-expensify://ENDPOINT_FROM_MESSAGE --android

example: npx uri-scheme open new-expensify://u/15604813/349410 --ios

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

I wasn't able to test redirect in the desktop version

kubabutkiewicz · 2023-12-13T13:59:58Z

src/libs/Navigation/types.ts

+        accountID?: string;
+        validateCode?: string;


why those changes? and also shouldn't accountID be a number? or its strings here as it is screen parameter?

Since UnlinkLoginPage had default values for these two params, I suggest they are optional. Otherwise, I can make it required but then it makes sense to get rid of default values here

const accountID = route.params.accountID ?? ''; const validateCode = route.params.validateCode ?? '';

which I'm not sure will not lead to regression...

src/pages/UnlinkLoginPage.tsx

src/libs/actions/Session/index.ts

kubabutkiewicz

lgtm

melvin-bot · 2023-12-14T14:57:00Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2023-12-16T16:22:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-17.at.23.50.23.-.android.mov

Android: mWeb Chrome

Screen.Recording.2023-12-17.at.20.50.35.android.chrome.mov

iOS: Native

Uploading Screen Recording 2023-12-17 at 20.44.05 - ios.mov…

iOS: mWeb Safari

Screen.Recording.2023-12-17.at.20.46.07.-.ios.safari.mov

MacOS: Chrome / Safari

Uploading Screen Recording 2023-12-17 at 20.03.45 - web.mov…

MacOS: Desktop

N/A

hoangzinh

LGTM

melvin-bot · 2023-12-17T16:51:36Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25171 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

marcochavezf

LGTM, thanks!

OSBotify · 2023-12-18T19:17:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-19T02:44:21Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T03:47:42Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-21T05:15:17Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.14-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[TS migration] Migrate 'UnlinkLogin' page

4b40b18

kubabutkiewicz reviewed Dec 13, 2023

View reviewed changes

pasyukevich reviewed Dec 13, 2023

View reviewed changes

src/libs/actions/Session/index.ts Outdated Show resolved Hide resolved

Update accountID default value

ea6e632

kubabutkiewicz approved these changes Dec 14, 2023

View reviewed changes

blazejkustra approved these changes Dec 14, 2023

View reviewed changes

VickyStash marked this pull request as ready for review December 14, 2023 14:56

VickyStash requested a review from a team as a code owner December 14, 2023 14:56

melvin-bot bot requested review from hoangzinh and removed request for a team December 14, 2023 14:56

hoangzinh approved these changes Dec 17, 2023

View reviewed changes

melvin-bot bot requested a review from marcochavezf December 17, 2023 16:51

marcochavezf approved these changes Dec 18, 2023

View reviewed changes

marcochavezf merged commit b12b512 into Expensify:main Dec 18, 2023

github-actions bot mentioned this pull request Dec 19, 2023

Deploy Checklist: New Expensify 2023-12-19 #33264

Closed

98 tasks

melvin-bot bot mentioned this pull request Dec 21, 2023

[$250][HOLD for payment 2023-12-28] [TS migration] Migrate 'UnlinkLogin' page to TypeScript #25171

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'UnlinkLogin' page to TypeScript #32966

[TS migration] Migrate 'UnlinkLogin' page to TypeScript #32966

VickyStash commented Dec 13, 2023 •

edited

Loading

kubabutkiewicz Dec 13, 2023

VickyStash Dec 13, 2023

kubabutkiewicz left a comment

melvin-bot bot commented Dec 14, 2023

hoangzinh commented Dec 16, 2023 •

edited

Loading

hoangzinh left a comment

melvin-bot bot commented Dec 17, 2023

marcochavezf left a comment

OSBotify commented Dec 18, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

[TS migration] Migrate 'UnlinkLogin' page to TypeScript #32966

[TS migration] Migrate 'UnlinkLogin' page to TypeScript #32966

Conversation

VickyStash commented Dec 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

kubabutkiewicz Dec 13, 2023

Choose a reason for hiding this comment

VickyStash Dec 13, 2023

Choose a reason for hiding this comment

kubabutkiewicz left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 14, 2023

hoangzinh commented Dec 16, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

hoangzinh left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 17, 2023

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 18, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 19, 2023

OSBotify commented Dec 21, 2023

VickyStash commented Dec 13, 2023 •

edited

Loading

hoangzinh commented Dec 16, 2023 •

edited

Loading