Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250][HOLD for payment 2023-12-28] [TS migration] Migrate 'UnlinkLogin' page to TypeScript #25171

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/UnlinkLoginPage.js 11
Issue OwnerCurrent Issue Owner: @isabelastisser
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

Copy link
Author

melvin-bot bot commented Dec 17, 2023

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hoangzinh
Copy link
Contributor

hi @marcochavezf, can you help to:

  1. Assign me to this issue
  2. Add the issue label "New Feature" or "Bug" to trigger adding a BZ member to this issue
    Thanks

@marcochavezf
Copy link
Contributor

Oh sure, doing it now

@marcochavezf marcochavezf added the Improvement Item broken or needs improvement. label Dec 21, 2023
@marcochavezf
Copy link
Contributor

Ah technically it's an improvement but that label didn't trigger a bz assignment

@marcochavezf marcochavezf added the NewFeature Something to build that is a new item. label Dec 21, 2023
Copy link
Author

melvin-bot bot commented Dec 21, 2023

@marcochavezf
Copy link
Contributor

Hi @isabelastisser, could you handle the payment for @hoangzinh for C+ review? Thanks!

@isabelastisser
Copy link
Contributor

@marcochavezf, can you please share the payment amount? Thanks!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'UnlinkLogin' page to TypeScript [HOLD for payment 2023-12-28] [TS migration] Migrate 'UnlinkLogin' page to TypeScript Dec 21, 2023
Copy link
Author

melvin-bot bot commented Dec 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 21, 2023
Copy link
Author

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @hoangzinh requires payment (Needs manual offer from BZ)

Copy link
Author

melvin-bot bot commented Dec 21, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 27, 2023
@marcochavezf
Copy link
Contributor

@marcochavezf, can you please share the payment amount? Thanks!

Using this other GH issue as reference, it's $250

@melvin-bot melvin-bot bot removed the Overdue label Dec 27, 2023
@marcochavezf marcochavezf changed the title [HOLD for payment 2023-12-28] [TS migration] Migrate 'UnlinkLogin' page to TypeScript [$250][HOLD for payment 2023-12-28] [TS migration] Migrate 'UnlinkLogin' page to TypeScript Dec 27, 2023
Copy link
Author

melvin-bot bot commented Dec 27, 2023

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2024
Copy link
Author

melvin-bot bot commented Jan 2, 2024

@marcochavezf, @hoangzinh, @isabelastisser Eep! 4 days overdue now. Issues have feelings too...

@marcochavezf
Copy link
Contributor

Not overdue, waiting for payment

@isabelastisser
Copy link
Contributor

@hoangzinh Please accept the offer in Upwork. Thanks!

@hoangzinh
Copy link
Contributor

Accepted. Thanks @isabelastisser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Not a priority Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants