Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Localization to Attachment Modal #2935

Merged
merged 1 commit into from
May 14, 2021

Conversation

thienlnam
Copy link
Contributor

@thienlnam thienlnam commented May 14, 2021

Details

Fixed Issues

Fixes #2844

Tests / QA

  1. Add Attachment, make sure the modal says Upload Attachment
    Screen Shot 2021-05-14 at 12 48 31 PM

  2. Click on the image and make sure a modal opens with the title Attachment

Screen Shot 2021-05-14 at 12 49 58 PM

For example:

  1. Click on the text input to bring it into focus
  2. Upload an image via copy paste
  3. Verify a modal appears displaying a preview of that image
    --->

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@thienlnam thienlnam self-assigned this May 14, 2021
@thienlnam thienlnam requested a review from a team as a code owner May 14, 2021 19:49
@thienlnam thienlnam requested a review from marcaaron May 14, 2021 19:49
@MelvinBot MelvinBot requested review from Luke9389 and MariaHCD and removed request for a team May 14, 2021 19:49
@thienlnam thienlnam mentioned this pull request May 14, 2021
5 tasks
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcaaron marcaaron merged commit 08ef270 into main May 14, 2021
@marcaaron marcaaron deleted the jack-addLocalizationToAttachmentModal branch May 14, 2021 21:12
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.46-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat - Sent images are not displayed in chat
3 participants