Fix Image Attachments

[thienlnam]

Details

Fixed Issues

Fixes #2844

Tests / QA Steps

1. Upload an image, and make sure it is viewable and that you can click it to open the image modal

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[roryabraham]

@thienlnam Do you want help testing this? Let's get screenshots for all platforms.

[thienlnam]

I was hoping to get localization back but still trying to figure out how to do that with this library. I'm also thinking we can just merge this since it will fix the images and figure out localization later. In that case, I can start testing on other platforms!

[thienlnam]

Tested on all platforms and they're working as expected, let's just get this out 👍

[roryabraham]

Agreed, let's fix this severe bug and then get localization fixed in a follow-up issue. @thienlnam Can you create an issue that describes the context behind this PR and explains why localization needs to be fixed in RenderHTML.js?

[roryabraham]

All yours @francoisl

[francoisl]

Works well on my side!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[thienlnam]

I chatted with Marc on how to re-add localization to the attachment title and the solution was to move the localization a layer down. The location where localization was added in RenderHTML.js was just making it so that our HTML renderer package wasn't recognizing img html as an image and never went through the img handling (I'm not familiar with the react-native-render-html library so I'm not totally sure why it was doing that, but I know that removing it made it go through the img handling again). I just went ahead and tagged my other PR #2935 to the original issue as it just adds back Localization

[OSBotify]

🚀 Deployed to staging in version: 1.0.46-1🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅