-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude Concierge from IOU flows (2nd attempt) #2841
Exclude Concierge from IOU flows (2nd attempt) #2841
Conversation
@@ -308,10 +308,10 @@ class ReportActionCompose extends React.Component { | |||
render() { | |||
// eslint-disable-next-line no-unused-vars | |||
const hasMultipleParticipants = lodashGet(this.props.report, 'participants.length') > 1; | |||
const hasConciergeParticipant = _.contains(this.props.report.participants, CONST.EMAIL.CONCIERGE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only this line has been changed compared to the previous PR #2740
Before:
const hasConciergeParticipant = this.props.report.participants.includes(CONST.EMAIL.CONCIERGE);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, and I appreciate that you added tests! Passing on to @roryabraham or @Luke9389 for final merge. Another note as I review this is that we should eventually update this from excludeConcierge
to excludeSupportEmails
or something similar and exclude Chronos as well
Merging this. Thanks for the fix here @tugbadogan, and @thienlnam & @Luke9389 for the reviews. |
🚀 Deployed to staging in version: 1.0.45-2🚀
|
🚀 Deployed to production in version: 1.0.46-0🚀
|
cc @Luke9389 @roryabraham
Details
This is a duplicate of #2740 and I'm using
_.contains()
to avoid crashing the app ifthis.props.report.participant
isundefined
.Fixed Issues
Fixes #2698
Tests
QA Steps
Q&A steps for group creation issue #2809
Tested On
Screenshots
Web