-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude concierge from iou #2740
Exclude concierge from iou #2740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tugbadogan. Would you mind also adding this functionality to the unit tests for getNewGroupOptions? Otherwise lookin' great 👍
Hi, I added unit tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! This is lookin' great!
Thanks for adding in these tests @tugbadogan.
Just a couple of questions, and a few NABs (Not a Blocker).
Comment back on whether you want to address the review comments, excluding default values is not something that I'd require (since they make the code a tad more informative). Still though, I wouldn't fault you if you were to take them out.
I do however need an answer on whether we default excludeConcierge to true
. I see that you're using some syntactic sugar when you pass it to getNewGroupOptions
and I just want to be sure I'm reading that right.
Thanks!
Thanks for the quick review @Luke9389 , I've addressed the comments and updated the PR |
Dang! Super speedy 🏎 |
Obligatory question after review rounds: you've tested this on all 5 platforms? |
Yes, I tested this on all platforms. I didn't put screenshots for other platforms since there's no UI element or platform specific change here. |
Ok cool 👍 I've got some internal stuff to do before I can merge this but I'll be back later today. Thanks for all the quick response times here! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.42-1🚀
|
🚀 Deployed to production in version: 1.0.44-0🚀
|
@trjExpensify
Details
Exclude Concierge from IOU participant selection and remove IOU menu items from chat with Concierge.
Fixed Issues
Fixes #2698
Tests
Tested manually and made sure that users cannot initiate IOU request with Concierge.
QA Steps
Tested On
Screenshots
Desktop