Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix <21137>: fixed cursor reset to beginning #22443

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix <21137>: fixed cursor reset to beginning #22443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/home/report/ReportActionItemMessageEdit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ function ReportActionItemMessageEdit(props) {
}
openReportActionComposeViewWhenClosingMessageEdit();
}}
selection={selection}
selection={!isFocused ? undefined : selection}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is causing where pasting text results in cursor misplacement. This was unable to find as it was blocked by another issue ##22803.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other PR is merged, left comment about the regression caused here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused this regression: #23451

onSelectionChange={(e) => setSelection(e.nativeEvent.selection)}
/>
</View>
Expand Down