[HOLD for payment 2023-08-03] [$1000] mWeb - Cannot set focus on draft message on iOS safari

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login with any account and go to any chat
2. Send two messages A and B
3. Edit message A(don't save or close)
4. Edit message B(don't save or close)
5. Touch on draft A

Expected Result:

A should be focused

Actual Result:

Nothing happens

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bandicam.2023-07-21.19-06-17-623.mp4

RPReplay_Final1690145577.MP4

Expensify/Expensify Issue URL:
Issue reported by: @s-alves10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689976646500919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b263c9f210b550ff
• Upwork Job ID: 1683590098125062144
• Last Price Increase: 2023-07-24
• Automatic offers:
• s-alves10 | Reporter | 25908943

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dummy-1111]

This issue is a regression of this PR

[joekaufmanexpensify]

Reproduced on my end.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b263c9f210b550ff

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[joekaufmanexpensify]

cc @Santhosh-Sellavel @thesahindia curious if you agree this is a regression?

[Santhosh-Sellavel]

@joekaufmanexpensify Yes reverting that fixes the issue, it's a regression!

[joekaufmanexpensify]

Got it. And this would be the second regression from that issue, right?

[Santhosh-Sellavel]

Yes

[Santhosh-Sellavel]

Let's remove help wanted here @joekaufmanexpensify

[joekaufmanexpensify]

Done! Commented in the other issue as well.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "fix <21137>: fixed cursor reset to beginning" #23518

If no regressions arise, payment will be issued on 2023-08-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR: fix <21137>: fixed cursor reset to beginning #22443
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/22443/files#r1282212633
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A regression.
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[joekaufmanexpensify]

@Santhosh-Sellavel Could you please complete your portion of the BZ checklist here when you have a sec?

[Santhosh-Sellavel]

@thesahindia please take care as this is a regression from this #22443

cc: @aldo-expensify

[melvin-bot]

📣 @Santhosh-Sellavel Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @thesahindia Please request via NewDot manual requests for the Contributor role ($1000)

[melvin-bot]

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[aldo-expensify]

oops, @thesahindia is not a contributor, I'm adding him to take care of the bug-zero checklist: #23451 (comment)

Why an upwork offer was sent to @s-alves10 ? bug?

[Santhosh-Sellavel]

As it says in the message for reporting the bug!

[aldo-expensify]

As it says in the message for reporting the bug!

Oh, I missed that, my bad :P

[joekaufmanexpensify]

@thesahindia could you please complete the rest of the BZ checklist here when you have a sec? Thanks!

[joekaufmanexpensify]

Since this was just reverting a regression, I think all we need to do is pay the $250 reporting bonus.

cc @Santhosh-Sellavel I don't see that you reviewed anything here, so thinking no payment is due, but LMK if that is different than your expectation!

[Santhosh-Sellavel]

Right only reporting bonus!

[joekaufmanexpensify]

Cool cool, ty!

[dummy-1111]

@joekaufmanexpensify

Can I get paid as a reporter?

[joekaufmanexpensify]

@s-alves10 We need to make sure the BZ checklist is complete before issuing payment. As soon as it is, I'll issue your payment!

[thesahindia]

The needed items are already filled in the checklist. It doesn't need a test case. It was a regression from #22443, we just have to keep this case in mind while fixing the original issue again.

[joekaufmanexpensify]

Got it, ty!

[joekaufmanexpensify]

All set to issue payment.

[joekaufmanexpensify]

@s-alves10 $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!