fix: long press app download links on mweb Safari to open the Copy to Clipboard menu #17310

akinwale · 2023-04-11T22:22:31Z

Details

Allow the app download links and other external links to display the Copy to Clipboard menu when a user long-presses the item. Refactor MenuItem to get rid of nested Pressables.

Fixed Issues

$ #16946
PROPOSAL: #16946 (comment)

Tests

Log in to any account
Open the Settings page.
Long-press the Help link. This should present the Copy to Clipboard overlay with the action and link displayed at the bottom.
Use the Copy to Clipboard action and verify the copied URL.
Open the About page.
Long-press the View the code link. This should present the Copy to Clipboard overlay.
Repeat step 4.
Long-press the View open jobs link. This should present the Copy to Clipboard overlay.
Repeat step 4.
Click on App download links.
Long-press on each of the links. The Copy to Clipboard overlay should be displayed after long-pressing each link.
Verify that copied URL matches for each of the links.

Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

16946-android-chrome.webm

Mobile Web - Safari

16946-ios-safari.mov

Desktop

iOS

16946-ios-native.mov

Android

16946-android-native.webm

…ome refactoring

MelvinBot · 2023-04-11T22:22:37Z

@mountiny @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/showPopover.js

src/components/MenuItem.js

src/components/PressableWithSecondaryInteraction/index.js

src/components/MenuItem.js

src/pages/settings/InitialSettingsPage.js

mountiny

Great job, and great comments from @eVoloshchak! I would really make sure we cover testing of all the platforms for where the MenuItem components is used since its quite often used component

akinwale · 2023-04-12T11:29:13Z

Great job, and great comments from @eVoloshchak! I would really make sure we cover testing of all the platforms for where the MenuItem components is used since its quite often used component

Thanks for the feedback. I manually tested the component on both (Android / iOS) native mobile and mobile web platforms, as well as desktop and regular web browsers.

src/pages/settings/AppDownloadLinks.js

eVoloshchak · 2023-04-12T15:39:49Z

@akinwale, besides one small change, the code looks good to me.
There are a couple of pages left this logic needs to be added to, namely GetAssistancePage and WorkspaceTravelVBAView (I think that's all the pages, but I'd appreciate it if you double-check once more if I missed something)

akinwale · 2023-04-12T15:57:27Z

@akinwale, besides one small change, the code looks good to me. There are a couple of pages left this logic needs to be added to, namely GetAssistancePage and WorkspaceTravelVBAView (I think that's all the pages, but I'd appreciate it if you double-check once more if I missed something)

@eVoloshchak I am unable to determine one of the links for WorkspaceTravelVBAView as it makes use of the Link.openOldDotLink method instead of an actual string constant. However, it looks like they defer to a component called Section which in turn renders a MenuItemList where the MenuItems are rendered. I will add the logic to MenuItemList and then the missing links that I cannot determine for the MenuItems can be updated in a separate PR. Is this ok?

eVoloshchak · 2023-04-12T16:39:58Z

@eVoloshchak I am unable to determine one of the links for WorkspaceTravelVBAView as it makes use of the Link.openOldDotLink method instead of an actual constant. However, it looks like they defer to a component called Section which in turn renders a MenuItemList where the MenuItems are rendered. I will add the logic to MenuItemList and then the missing links that I cannot determine for the MenuItems can be updated in a separate PR. Is this ok?

I think it's possible to determine the link. If we move buildOldDotURL into the upper scope (so it can be called using Link.buildOldDotURL), we can then add the following here:

link: Link.buildOldDotURL('domain_companycards')

akinwale · 2023-04-12T16:43:10Z

@eVoloshchak I am unable to determine one of the links for WorkspaceTravelVBAView as it makes use of the Link.openOldDotLink method instead of an actual constant. However, it looks like they defer to a component called Section which in turn renders a MenuItemList where the MenuItems are rendered. I will add the logic to MenuItemList and then the missing links that I cannot determine for the MenuItems can be updated in a separate PR. Is this ok?

I think it's possible to determine the link. If we move buildOldDotURL into the upper scope (so it can be called using Link.buildOldDotURL), we can then add the following here:
link: Link.buildOldDotURL('domain_companycards')

I don't think this will work. The buildldDotURL takes a shortLivedAuthToken as a parameter, which is different from the url parameter that is passed to openOldDotLink. This seems like it would be a more complex implementation. Also, I feel that it's beyond the scope of this PR.

eVoloshchak · 2023-04-12T16:47:54Z

The buildldDotURL takes a shortLivedAuthToken

It's optional: If shortLivedAuthToken is not accessible, fallback to opening the link without the token, so all we need to do is move it to the upper scope

Also, I feel that it's beyond the scope of this PR.

I'm not too sure about that, the original requirement was: any menu item which is a link should have this behaviour

akinwale · 2023-04-12T16:58:36Z

The buildldDotURL takes a shortLivedAuthToken

It's optional: If shortLivedAuthToken is not accessible, fallback to opening the link without the token, so all we need to do is move it to the upper scope

Also, I feel that it's beyond the scope of this PR.

I'm not too sure about that, the original requirement was: any menu item which is a link should have this behaviour

The buildOldDotURL method returns a promise. Therefore assigning it to link property directly as you demonstrated still wouldn't work.

It is out of scope because it's a refactor of business logic for building old URLs. The logic for the handling of links to display the Copy to Clipboard menu has already been implemented in the MenuItemList. The only thing left that's left is to set the link property for this particular link. If I can get the actual URL that this points to, then I can define a new constant and use that instead.

akinwale · 2023-04-12T17:09:47Z

@eVoloshchak
Looking at the method, it looks like the resulting URL will be https://www.expensify.com/domain_companycards. Can you confirm if this is correct? We can just define a string constant in WorkspaceTravelVBAView and set it to this.

eVoloshchak · 2023-04-12T17:17:56Z

@eVoloshchak Looking at the method, it looks like the resulting URL will be https://www.expensify.com/domain_companycards. Can you confirm if this is correct? We can just define a string constant in WorkspaceTravelVBAView and set it to this.

It also contains current email, so we can't define it as a constant
https://www.expensify.com.dev/domain_companycards?email=someemail%2B01%40gmail.com

I'm investigating how we can get the result of buildOldDotURL, hold on

eVoloshchak · 2023-04-12T17:50:08Z

@akinwale, we can add the following here:

link: () => Link.buildOldDotURL('domain_companycards')

And then in MenuItemList
onSecondaryInteraction={e => onSecondaryInteraction(menuItemProps.link, e)}, where

    const onSecondaryInteraction = (link, e) => {
        if (typeof link === 'function') {
            link().then(url => ReportActionContextMenu.showContextMenu(CONTEXT_MENU_TYPES.LINK, e, url, popoverAnchor));
        } else if (!_.isEmpty(link)) {
            ReportActionContextMenu.showContextMenu(CONTEXT_MENU_TYPES.LINK, e, link, popoverAnchor);
        }
    };

src/pages/workspace/travel/WorkspaceTravelVBAView.js

ios/Podfile.lock

src/components/PressableWithSecondaryInteraction/index.js

eVoloshchak · 2023-04-13T19:46:40Z

src/components/MenuItemList.js

+            {_.map(props.menuItems, menuItemProps => (
+                <MenuItem
+                    key={menuItemProps.title}
+                    onSecondaryInteraction={_.isEmpty(menuItemProps.link) ? e => secondaryInteraction(menuItemProps.link, e) : undefined}


This works but I don't understand why.
Why are we calling secondaryInteraction if link is empty? Shouldn't it be the other way around?
UPD: It doesn't work properly, it opens the context menu only if link is a function

It shoud be !_.isEmpty. Let me double-check.

Yeah, I'll have to explicitly check if it's a function first before isEmpty. eslint complains about explicitly converting to Boolean.

I haven't tested, but maybe _.isUndefined will be of help

That's a better option, thanks.

eVoloshchak · 2023-04-13T20:22:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-04-13.at.23.20.32.mov

Mobile Web - Chrome

Screen_Recording_20230413-231250_Chrome.mp4

Mobile Web - Safari

IMG_0016.MP4

Desktop

Screen.Recording.2023-04-13.at.23.18.59.mov

iOS

IMG_0015.MP4

Android

Screen_Recording_20230413-231203_New.Expensify.mp4

eVoloshchak

Looks good and tests well!
cc: @mountiny

AndrewGable

Not super involved in initial proposal, but code looks good to me. Leaving merge for @mountiny

mountiny

Great job on this one both @akinwale and @eVoloshchak thanks!

OSBotify · 2023-04-15T00:04:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-18T04:39:33Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-18T06:09:09Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

This reverts commit 4607dcb, reversing changes made to 6ee5e7a.

Revert "Merge pull request #17310 from akinwale/task-16946"

Revert "Merge pull request #17310 from akinwale/task-16946" (cherry picked from commit 479b6ed)

OSBotify · 2023-04-19T17:22:18Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.1-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-19T18:04:32Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-20T22:00:53Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.2-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

akinwale added 2 commits April 11, 2023 21:10

avoid nested Pressable and change the root MenuItem component, with s…

186d91f

…ome refactoring

use React.forwardRef for MenuItem, and fix prop types

38933dd

akinwale requested a review from a team as a code owner April 11, 2023 22:22

melvin-bot bot requested review from eVoloshchak and mountiny and removed request for a team April 11, 2023 22:22

eVoloshchak suggested changes Apr 12, 2023

View reviewed changes

mountiny assigned akinwale Apr 12, 2023

mountiny reviewed Apr 12, 2023

View reviewed changes

akinwale added 2 commits April 12, 2023 12:16

changes based on PR review feedback

e03eafe

clean up onPressOut in MenuItem component

c1ec517

akinwale requested a review from eVoloshchak April 12, 2023 11:44

eVoloshchak suggested changes Apr 12, 2023

View reviewed changes

src/pages/settings/AppDownloadLinks.js Outdated Show resolved Hide resolved

akinwale requested a review from eVoloshchak April 12, 2023 16:37

akinwale force-pushed the task-16946 branch 2 times, most recently from a7829b6 to 206bf05 Compare April 12, 2023 18:21

eVoloshchak suggested changes Apr 12, 2023

View reviewed changes

src/pages/workspace/travel/WorkspaceTravelVBAView.js Outdated Show resolved Hide resolved

ios/Podfile.lock Outdated Show resolved Hide resolved

implement Copy to Clipboard behaviour for all links

7b4f455

akinwale force-pushed the task-16946 branch from 206bf05 to 7b4f455 Compare April 12, 2023 18:29

akinwale requested a review from eVoloshchak April 13, 2023 19:26

eVoloshchak reviewed Apr 13, 2023

View reviewed changes

src/components/PressableWithSecondaryInteraction/index.js Show resolved Hide resolved

eVoloshchak reviewed Apr 13, 2023

View reviewed changes

src/components/PressableWithSecondaryInteraction/index.js Show resolved Hide resolved

add JSDoc for executeSecondaryInteraction

0fc1675

akinwale requested a review from eVoloshchak April 13, 2023 19:41

eVoloshchak reviewed Apr 13, 2023

View reviewed changes

fix onSecondaryInteraction prop check in MenuItemList

00cd2d6

akinwale requested a review from eVoloshchak April 13, 2023 20:06

eVoloshchak approved these changes Apr 13, 2023

View reviewed changes

AndrewGable approved these changes Apr 14, 2023

View reviewed changes

mountiny approved these changes Apr 14, 2023

View reviewed changes

mountiny merged commit 4607dcb into Expensify:main Apr 14, 2023

OSBotify mentioned this pull request Apr 17, 2023

Deploy Checklist: New Expensify 2023-04-17 #17546

Closed

53 tasks

flodnv mentioned this pull request Apr 18, 2023

[HOLD for payment 2023-04-27] [HOLD for payment 2023-04-26] Workspace - When deleting a workspace offline. the layout breaks #17580

Closed

6 tasks

mountiny added a commit that referenced this pull request Apr 18, 2023

Revert "Merge pull request #17310 from akinwale/task-16946"

0f38d3d

This reverts commit 4607dcb, reversing changes made to 6ee5e7a.

mountiny mentioned this pull request Apr 18, 2023

Revert "Merge pull request #17310 from akinwale/task-16946" #17618

Merged

56 tasks

AndrewGable added a commit that referenced this pull request Apr 18, 2023

Merge pull request #17618 from Expensify/vit-revert17310

479b6ed

Revert "Merge pull request #17310 from akinwale/task-16946"

OSBotify pushed a commit that referenced this pull request Apr 18, 2023

Merge pull request #17618 from Expensify/vit-revert17310

253587d

Revert "Merge pull request #17310 from akinwale/task-16946" (cherry picked from commit 479b6ed)

kbecciv mentioned this pull request Apr 18, 2023

App download links - Long pressing any of the app download link does not open the copy to clipboard menu #17641

Closed

6 tasks

akinwale mentioned this pull request Apr 18, 2023

fix: when deleting a workspace offline, the layout breaks #17639

Merged

56 tasks

OSBotify mentioned this pull request Apr 19, 2023

Deploy Checklist: New Expensify 2023-04-19 #17671

Closed

37 tasks

MelvinBot mentioned this pull request Apr 19, 2023

[HOLD for payment 2023-05-03] [$1000] Long pressing any of the app download link on mweb Safari does not open the copy to clipboard menu #16946

Closed

6 tasks

akinwale mentioned this pull request Apr 20, 2023

[PAID] [$500] Workspace - Deleted Workspace offline is not crossed out #17656

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: long press app download links on mweb Safari to open the Copy to Clipboard menu #17310

fix: long press app download links on mweb Safari to open the Copy to Clipboard menu #17310

akinwale commented Apr 11, 2023 •

edited

Loading

MelvinBot commented Apr 11, 2023

mountiny left a comment

akinwale commented Apr 12, 2023

eVoloshchak commented Apr 12, 2023

akinwale commented Apr 12, 2023 •

edited

Loading

eVoloshchak commented Apr 12, 2023

akinwale commented Apr 12, 2023 •

edited

Loading

eVoloshchak commented Apr 12, 2023 •

edited

Loading

akinwale commented Apr 12, 2023

akinwale commented Apr 12, 2023

eVoloshchak commented Apr 12, 2023

eVoloshchak commented Apr 12, 2023

eVoloshchak Apr 13, 2023 •

edited

Loading

akinwale Apr 13, 2023

akinwale Apr 13, 2023 •

edited

Loading

eVoloshchak Apr 13, 2023

akinwale Apr 13, 2023

eVoloshchak commented Apr 13, 2023 •

edited

Loading

eVoloshchak left a comment

AndrewGable left a comment

mountiny left a comment

OSBotify commented Apr 15, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 19, 2023

OSBotify commented Apr 19, 2023

OSBotify commented Apr 20, 2023

fix: long press app download links on mweb Safari to open the Copy to Clipboard menu #17310

fix: long press app download links on mweb Safari to open the Copy to Clipboard menu #17310

Conversation

akinwale commented Apr 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 11, 2023

mountiny left a comment

Choose a reason for hiding this comment

akinwale commented Apr 12, 2023

eVoloshchak commented Apr 12, 2023

akinwale commented Apr 12, 2023 • edited Loading

eVoloshchak commented Apr 12, 2023

akinwale commented Apr 12, 2023 • edited Loading

eVoloshchak commented Apr 12, 2023 • edited Loading

akinwale commented Apr 12, 2023

akinwale commented Apr 12, 2023

eVoloshchak commented Apr 12, 2023

eVoloshchak commented Apr 12, 2023

eVoloshchak Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

akinwale Apr 13, 2023

Choose a reason for hiding this comment

akinwale Apr 13, 2023 • edited Loading

Choose a reason for hiding this comment

eVoloshchak Apr 13, 2023

Choose a reason for hiding this comment

akinwale Apr 13, 2023

Choose a reason for hiding this comment

eVoloshchak commented Apr 13, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

AndrewGable left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 15, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 18, 2023

OSBotify commented Apr 19, 2023

OSBotify commented Apr 19, 2023

OSBotify commented Apr 20, 2023

akinwale commented Apr 11, 2023 •

edited

Loading

akinwale commented Apr 12, 2023 •

edited

Loading

akinwale commented Apr 12, 2023 •

edited

Loading

eVoloshchak commented Apr 12, 2023 •

edited

Loading

eVoloshchak Apr 13, 2023 •

edited

Loading

akinwale Apr 13, 2023 •

edited

Loading

eVoloshchak commented Apr 13, 2023 •

edited

Loading