[HOLD for payment 2023-04-27] [HOLD for payment 2023-04-26] Workspace - When deleting a workspace offline. the layout breaks

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account that is ready for Error tests
3. Turn off internet connection
4. Delete a workspace while offline

Expected Result:

User expects the layout to continue even when offline

Actual Result:

Layout breaks

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.1.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

https://expensify.testrail.io/index.php?/runs/view/14829&group_by=cases:section_id&group_order=asc&group_id=229065

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[kbecciv]

Attaching TR picture to reproduce the issue

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[flodnv]

Can confirm, I reproduced on staging web, but not on prod.

[flodnv]

I looked at the PRs in #17546, nothing stands out. I am going to use git bisect to find the offending PR, unless someone chimes in here: https://expensify.slack.com/archives/C01GTK53T8Q/p1681836208585709

[flodnv]

Reverting #17310 locally fixes it, so that PR caused it. Assigning everyone who was involved to decide what to do 🙃

[flodnv]

For some reason I cannot assign @akinwale

[AndrewGable]

I think he has to comment on the issue to assign him first. @mountiny - I'd propose a straight revert, thoughts?

[mountiny]

@akinwale is looking into this, can you comment here please? Confirming if straight revert fixes this. There might be some other considerations.

[mountiny]

revert Pr is in review.

[mountiny]

fixed in staging

[akinwale]

From what I found, there was an issue with defaultProps being disregarded (or discarded?) when the MenuItem is wrapped by a HOC.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.1-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Merge pull request #17310 from akinwale/task-16946" #17618

If no regressions arise, payment will be issued on 2023-04-26. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.2-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "Merge pull request #17310 from akinwale/task-16946" #17618

If no regressions arise, payment will be issued on 2023-04-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty