-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OptionsSelector - delay input focus on android only #10194
OptionsSelector - delay input focus on android only #10194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. I'll let @sketchydroide do a review too considering they've got more context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the changes look good
Will merge once conflicts are addressed @rushatgabhane |
good to merge? @sketchydroide |
β This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Note: There are prop validation console errors due to this PR. |
Thanks @parasharrajat I'll fix them with a follow-up PR |
Thanks @rushatgabhane |
/> | ||
)); | ||
|
||
OptionsSelector.propTypes = propTypes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for letting me know!
Fix is here - #10763
cc: @sketchydroide requesting your review! πββοΈ
Details
We added
shouldDelayFocus
toOptionsSelector
in Search page. But it caused this issue again - #6069 (regression)This PR makes OptionsSelector to always use
shouldDelayFocus
for Android.Other platforms didn't need a delay (as evident by the videos attached)
Fixed Issues
$ #9827
Tests
Test # 1
Test # 2
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Test # 1
Test # 2
Screenshots
Web
Screen.Recording.2022-08-02.at.10.57.51.AM.mov
Mobile Web
screen-20220802-111206.mp4
Screen.Recording.2022-08-02.at.10.51.53.AM.mov
Desktop
Screen.Recording.2022-08-02.at.11.16.06.AM.mov
iOS
Screen.Recording.2022-08-02.at.10.50.48.AM.mov
Android
screen-20220802-124949.mp4