-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay focus to Text Input in Search Page #15323
Conversation
The solution I can think of now for the original issue is to delay putting focus on the text field in Search Page a little bit so that the blur focus event on Global Creation Menu takes place before putting focus on the text field. Ideally, we want to only delay for the above situation. We don't want to delay putting focus for other situations (ex. when navigating to Search Page by clicking the search icon). However, I couldn't find any way to figure out what triggered navigation to Search Page. The Search Page cannot check whether or not Global Creation Menu was open when the navigation took place. So the only solutions I can think of is to delay putting focus in the input box in Search Page for all situations. If anyone has workaround for this, I would appreciate your suggestions. |
I marked this PR as "Ready for Review" so that PullerBear can assign reviewers. I'll complete PR Author Checklist after I receive feedback to the above comment and make appropriate modifications. |
@sobitneupane @aldo-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@aldo-expensify could you give feedback on my comment? |
This does not need to be reviewed @sobitneupane! |
Closing this PR as I marked the original issue external to seek proposals as per this comment. |
Details
Fixed Issues
$ #15276
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android