[Due for payment 2025-02-18] Android & iOS - Book travel - Book travel button only works when tapping for the second time

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.90-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+100106kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Other

Action Performed:

1. Launch hybrid or ND app.
2. Open FAB.
3. Tap Book Travel.
4. Tap Book travel one time.
5. Tap Book travel again.

Expected Result:

Tapping Book travel one time will open the address page.

Actual Result:

Tapping Book travel one time does nothing.

It only opens the address page after tapping Book travel for the second time.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6725773_1738039887315.ScreenRecording_01-28-2025_12-48-10_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[techievivek]

I think we can can remove the blocker label since the feature is behind beta?

[techievivek]

Seems to be coming from here #55300, cc @cristipaval

[techievivek]

Also, we have no plans of reverting that PR and the feature is still behind beta with users mainly on oldDot. https://expensify.slack.com/archives/C05S5EV2JTX/p1738013139945179?thread_ts=1737494593.720669&cid=C05S5EV2JTX

[techievivek]

Assigned it to you since you will be looking into the improvements/cleanups.

[layacat]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-28 10:32:27 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Book travel button only works when tapping for the second time

What is the root cause of that problem?

Unlike web, the first time we clicked the button the below subscription was started running:

App/src/libs/actions/Travel.ts

Lines 29 to 35 in 28cb413

	let activePolicyID: OnyxEntry<string>;
	Onyx.connect({
	key: ONYXKEYS.NVP_ACTIVE_POLICY_ID,
	callback: (val) => {
	activePolicyID = val;
	},
	});

activePolicyID will be undefined at the time we click the Book travel button and because we early returned if activePolicyID is undefined. Which caused the issue.

What changes do you think we should make in order to solve the problem?

Let's use the activePolicyID directly from here:

App/src/pages/Travel/ManageTrips.tsx

Line 35 in 00f5edd

const [activePolicyID] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID);

and pass it as a param to bookATrip function.
We can also add a loading state to BookTravel button while activePolicyID is loading by using useOnyx

const [activePolicyID, activePolicyIDResult] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID); 

While activePolicyIDResult.status is loading, we should show a loading indicator on BookTravel button.

We should also do the same approach for primaryLogin and isSingleNewDotEntry, we should pass it as a param and get their values from useOnyx instead.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[github-actions]

⚠️ @layacat Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[layacat]

Updated proposal to correct the format

[cristipaval]

I'll open a fix PR

[cristipaval]

Demoting, not to block the deployment with this, since it is for Travel which is behind a beta.

Working on a fix, which seems to have significant changes. I'll fix this as part of this refactoring issue. ETA: the PR should be ready at the end of today.

[cristipaval]

Update: The work on the PR that fixes this issue is done, but I asked for an early review from @tgolen. If I get his approval on the refactoring approach, then I will spend time on testing and recordings.

[cristipaval]

Update: The PR is approved, and the C+ is testing on all platforms so we hope it gets merged soon 🤞

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor bookATrip function #55852

If no regressions arise, payment will be issued on 2025-02-18. 🎊

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

@ZhenjaHorbach @trjExpensify @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@tgolen @trjExpensify @cristipaval @ZhenjaHorbach this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[trjExpensify]

This has been deployed Melv, we're waiting out the regression period. Chill man. 😅

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ZhenjaHorbach paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@trjExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[trjExpensify]

👋 @ZhenjaHorbach checklist time, please!

[ZhenjaHorbach]

Working on a fix, which seems to have significant changes. I'll fix this as part of this refactoring issue. ETA: the PR should be ready at the end of today.

Actually I'm not sure a checklist is needed here
Since it was part of the refactoring of the new functionality

[trjExpensify]

We should still fill out the checklist and state it as a bug with the initial implementation.

[ZhenjaHorbach]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  This issue was handled as a part of new feature

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Test:

1. Launch hybrid or ND app
2. Open FAB
3. Tap Book Travel
4. Verify that tapping Book travel one time will open a next screen

Do we agree 👍 or 👎

[trjExpensify]

Thanks! Payment summary as follows:

• $250 to @ZhenjaHorbach for the C+ review

Offer sent!

[ZhenjaHorbach]

Thanks! Payment summary as follows:

• $250 to @ZhenjaHorbach for the C+ review

Offer sent!

Done
Thanks !

[trjExpensify]

Paid, closing!