[$250] [HOLD for payment 2025-02-17] [CRITICAL] Add dropdown to allow users to choose which domain their travel should be provisioned under in NewDot

[stitesExpensify]

Problem

Currently when we provision travel, we use the domain of the billing owner for that policy. This works fine in most cases, but if there is an external accountant set as the owner, then the policy would be provisioned under that company which is incorrect and would need to be manually fixed by us.

Solution

When enabling travel, display a dropdown that includes all domains of members on the policy with a question like "Which company does this workspace belong to?"

This will then be passed to the backend and placed underneath that spotnana company

After this long thread, we landed on the following solution:

1. When a policy has members in more than one domain let them choose which domain they want to provision on

• We will show (recommended) in front of the most used domain in that policy

2. If they choose a policy they don’t have access to the domain prompt them to ask for a domain admin/become an A!

• Not having access to the domain means either:
  • Not having an email on that domain
  • Not being a domain admin

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021891556443234572502
• Upwork Job ID: 1891556443234572502
• Last Price Increase: 2025-02-17
• Automatic offers:
• ZhenjaHorbach | Contributor | 106161952

Issue Owner

Current Issue Owner: @brunovjk

[stitesExpensify]

Original issue: https://github.com/Expensify/Expensify/issues/445940

[ZhenjaHorbach]

I can help with this !

[melvin-bot]

@dannymcclain, @cristipaval, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ZhenjaHorbach]

Not overdue
PR is in progress !

[cristipaval]

Auth PR is merged and deployed.
Web-E PR is up
App PR is up but held on the Web-E PR

[cristipaval]

Backend PRs are deployed.

App PR passed the design review and it is being reviewed by the C+

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@tgolen, @garrettmknight, @dannymcclain, @cristipaval, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[garrettmknight]

Looks like that PR went to prod. @ZhenjaHorbach any others expected?

[ZhenjaHorbach]

Looks like that PR went to prod. @ZhenjaHorbach any others expected?

I hope that's all 😄

[garrettmknight]

Cool, we'll wait till payout then! @cristipaval do we need a regression test for this one or is it being handled elsewhere?

[cristipaval]

do we need a regression test for this one or is it being handled elsewhere?

Good question! I think we'll add regression tests when we enable travel for everyone, right now Applause can't really test this. @stitesExpensify what do you think?

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ZhenjaHorbach paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@garrettmknight)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[cristipaval]

@garrettmknight I think we're good to issue the payment for @ZhenjaHorbach here

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021891556443234572502

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[garrettmknight]

All paid up!