fix(p2p): consistent checks before connecting #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the logic that prevents us from connecting to banned nodes or creating duplicate connections to any node. Some of that logic was only applied for connecting to a set of nodes, but not on attempts to connect to a single node like through the rpc `connect call. All general checks have been moved to the `addOutbound` method which is a key method that all outgoing peer connection attempts go through.
michael1011
approved these changes
Oct 18, 2018
moshababo
approved these changes
Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the logic that prevents us from connecting to banned nodes or creating duplicate connections to any node. Some of that logic was only applied for connecting to a set of nodes, but not on attempts to connect to a single node like through the rpc
connect call. All general checks have been moved to theaddOutbound` method which is a key method that all outgoing peer connection attempts go through.