Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check banned, self and others BEFORE connection #352

Closed
kilrau opened this issue Aug 16, 2018 · 3 comments
Closed

Check banned, self and others BEFORE connection #352

kilrau opened this issue Aug 16, 2018 · 3 comments
Assignees
@sangaman
Labels
p2p Peer to peer networking P2 mid priority
Milestone
1.0.0-alpha.2

Comments

@kilrau
Copy link
Contributor

kilrau commented Aug 16, 2018

As per #315 (comment) all these checks should be done on client side BEFORE connection is attempted.
@kilrau kilrau added the p2p Peer to peer networking label Aug 16, 2018
@kilrau kilrau added this to the 1.0.0-alpha.2 milestone Aug 16, 2018
@kilrau kilrau added the P2 mid priority label Aug 16, 2018
@kilrau kilrau mentioned this issue Aug 16, 2018
Merged
@sangaman
Copy link
Collaborator

Self is done in #315, plus we check to make sure we're not already connected, so really only the banned logic needs work.

@kilrau kilrau modified the milestones: 1.0.0-alpha.1, 1.0.0-alpha.2 Sep 6, 2018
@kilrau kilrau mentioned this issue Sep 6, 2018
Closed
@kilrau
Copy link
Contributor Author

kilrau commented Oct 24, 2018

@sangaman can be closed?

@sangaman
Copy link
Collaborator

Yes, I believe this is fixed by #592. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangaman sangaman

Labels
p2p Peer to peer networking P2 mid priority
Projects
None yet
Milestone
1.0.0-alpha.2
Development

No branches or pull requests
2 participants
@sangaman @kilrau