P2P Improvements Overview

[kilrau]

This issue is to track P2P improvements which we want to have done in alpha.2:

• Switch off P2P functionality by default Make P2P functionality configurable #434
• Permanently disconnect from a node Permanently disconnect from a node #336
• Try to connect to each node only ONCE Track pending outgoing connections to peers #398
• Learn about new nodes at runtime [Concept] Learn about new nodes at runtime #262
• Store successful connected peers, even though no listening address advertised Store an external address if we successfully make an outgoing connection  #365
• Tag last successful address of a peer Reconnect to last successful address of a peer first #442
• Enhance shared peer info Enhance shared peers info #403
• GET_NODES periodically GET_NODES periodically #402
• Check banned before connection attempt Check banned, self and others BEFORE connection #352
• Peer/Node data structures Peers/Node Data Structures #185
• Advertise version Advertise version #154

[moshababo]

Open issues:

• Advertise version Advertise version #154: we're waiting with it for later stage.
• GET_NODES periodically GET_NODES periodically #402: let's continue the discussion.

[sangaman]

We should already have logic to reconnect to the last successful address of a peer per #496.

[kilrau]

#154 -> alpha.3
#402 -> alpha.4 (reconnect to last successful address is not part of it as @sangaman pointed out)

[moshababo]

Yes, I fixed the title.

[kilrau]

Only #154 & #402 are left, won't need this overview issue anymore. Closing.