Repeater Thumbnail Alignment #873
Conversation
|
Note: we should look this over before merging it and decide if we really want this approach. While the justified thumbnails look great with full rows... with a row of say, 3 thumbnails, it looks a bit odd. |
|
|
||
| var eachFunc = function(){ | ||
| //these dumb functions are necessary because lint yells when a function is in a loop :\ |
There was a problem hiding this comment.
i would encourage you to research this to see if it is "dumb" or not. we can tell jshint to ignore if we determine it is dumb but i think we should keep it. first find after googling
There was a problem hiding this comment.
Fair point. The comment is meant to indicate why this potentially unusual decision was made. That being said, it is not necessarily "dumb" so I'll remove that word :)
|
@swilliamset - updated. Still seeing this though: https://dl.dropboxusercontent.com/u/12146987/justified.png Any opinion on that? @interactivellama, your opinion here would be helpful as well |
|
Technically still justified. Maybe centering or providing an option to left/center/justify/right. Each has it's pros and cons but work as expected. |
|
@swilliamset - interesting... could be a |
|
bingo i like that. what should the default be? |
|
I made the default 'justify' but if others think another setting should be default I can easily change it :) Adding unit tests here in a sec |
| @@ -19,6 +19,37 @@ | |||
| padding: 6px; | |||
| width: 100%; | |||
|
|
|||
| &.align-center, &.align-justify, &.align-left, &.align-right { | |||
| position: relative; | |||
| text-align: justify; | |||
There was a problem hiding this comment.
Let's not specify this and then override it below. Let's just add a &.align-justify rule below.
… justify solution repeater-thumbnail-justify: fix to 'thumbnail_setSelectedItems' after making justify changes, which also makes unit tests pass repeater-thumbnail-justify: yet another minor fix because lint yells about something dumb repeater-thumbnail-justified: minor touchups after review repeater-thumbnail-justified: additional function name improvements repeater-thumbnail-justified: converted to thumbnail_alignment option instead so now center / justify / left / right (as well as 'none' or false) is supported repeater-thumbnail-justified: added unit tests. also added "spacer" class to injected spans repeater-thumbnail-justified: added default font-size for thumbnail
083548c to
c5e7e74
Compare
Repeater Thumbnail Alignment
fixes #851 by adding a
thumbnail_alignmentoption