This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
adjust template and style to allow thumbnail rows to justify #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6971a97 to
0c5c9ee
Compare
0c5c9ee to
64d96e0
Compare
|
I believe this looks better, especially if the repeater is on the left and there's another column on the right. From the little bit of feedback on the repeater thumbnail view that we got, designers said they wanted the blank area on the right. I'll try to double check on this. |
|
Design got back with me. You approved! I'll merge this in today. |
interactivellama
added a commit
that referenced
this pull request
Nov 21, 2014
adjust thumbnail template and style to allow thumbnail rows to justify
interactivellama
added a commit
that referenced
this pull request
Nov 21, 2014
kevinparkerson
pushed a commit
that referenced
this pull request
Dec 3, 2014
… justify solution repeater-thumbnail-justify: fix to 'thumbnail_setSelectedItems' after making justify changes, which also makes unit tests pass repeater-thumbnail-justify: yet another minor fix because lint yells about something dumb repeater-thumbnail-justified: minor touchups after review repeater-thumbnail-justified: additional function name improvements repeater-thumbnail-justified: converted to thumbnail_alignment option instead so now center / justify / left / right (as well as 'none' or false) is supported repeater-thumbnail-justified: added unit tests. also added "spacer" class to injected spans repeater-thumbnail-justified: added default font-size for thumbnail
BenjaminNeilDavis
pushed a commit
to BenjaminNeilDavis/fuelux
that referenced
this pull request
Dec 5, 2014
# The first commit's message is: (848---simplified-checkbox-fix) fixes issue #848 where checkbox breaks from rapid clicking # This is the 2nd commit message: Tree: Hide chervron for folder that doesn't have children #860 Selected background changed Selected background changed # This is the 3rd commit message: release 3.3.1 # This is the 4th commit message: (890---checkbox-not-clickable) fixed issue #890 and added appropriate unit tests # This is the 5th commit message: (893---grunt-serve-fast-not-watching) added watch:contrib to servefast to keep it from shutting down immediately # This is the 6th commit message: repeater-thumbnail-justify: fixes ExactTarget#851 by coming up with an alternate justify solution repeater-thumbnail-justify: fix to 'thumbnail_setSelectedItems' after making justify changes, which also makes unit tests pass repeater-thumbnail-justify: yet another minor fix because lint yells about something dumb repeater-thumbnail-justified: minor touchups after review repeater-thumbnail-justified: additional function name improvements repeater-thumbnail-justified: converted to thumbnail_alignment option instead so now center / justify / left / right (as well as 'none' or false) is supported repeater-thumbnail-justified: added unit tests. also added "spacer" class to injected spans repeater-thumbnail-justified: added default font-size for thumbnail # This is the 7th commit message: repeater-default-filter: Fixes #899 by making the default filter an object closely resembling what would be passed back by the selectlist if it were there # This is the 8th commit message: repeater-render-dataparams: Fixes #895 by allowing repeater render method to be passed dataSourceOptions which are then applied on top of whatever would be passed to the dataSource normally # This is the 9th commit message: (890---checkbox-not-clickable) fixed checkbox firing twice in Chrome # This is the 10th commit message: (890---checkbox-not-clickable) removed Paul Irish and added Dave Woodward # This is the 11th commit message: repeater-persisting-dataopts: Fixes #902 by allowing the repeater to preserve custom dataSource options # This is the 12th commit message: repeater-persisting-dataopts: minor modification to logic, preserves previously preserved dataSourceOptions instead of nuking them # This is the 13th commit message: updating dist # This is the 14th commit message: Utilizing less to make file more readable # This is the 15th commit message: Utilizing less to make file more readable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mbeard shared this with you earlier.
Some repeater thumbnail fun to enable the pattern linked bellow. Requires some extra markup to enforce spacing because of how templates are cleaned up (whitespace removed) [handlebars or jquery's fault]. Cleaner implementation suggestions welcomed.
http://css-tricks.com/equidistant-objects-with-css/