Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Improving Chrome focus highlighting #804

Merged
merged 2 commits into from
Oct 27, 2014
Merged

Improving Chrome focus highlighting #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a66e78
repeater-chrome-highlight: addresses issue #726 by changing chrome's …
Oct 27, 2014
93d62d5
repeater-chrome-highlight: added comment to clarify enter key trigger…
Oct 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/repeater-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,8 @@
// allow selection via enter key
$item.keyup(function (e) {
if (e.keyCode === 13) {
$item.trigger('clicked.fu.repeaterList');
// triggering a standard click event to be caught by the row click handler above
$item.trigger('click.fu.repeaterList');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought all our events are supposed to be "past-tense"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not this one - it is not triggered on this.$element and is instead used to trigger the row handler before it for accessibility.

}
});
}
Expand Down
4 changes: 4 additions & 0 deletions less/repeater-list.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@
}

tr {
&:focus {
outline: 1px dotted #66afe9;
}

&.empty {
td {
border-bottom: none;
Expand Down