This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Improving Chrome focus highlighting #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…highlight on focus of rows to be more visually-appealing; also fixes minor accessibility bug when attempting to select rows via enter key
| @@ -436,7 +436,7 @@ | |||
| // allow selection via enter key | |||
| $item.keyup(function (e) { | |||
| if (e.keyCode === 13) { | |||
| $item.trigger('clicked.fu.repeaterList'); | |||
| $item.trigger('click.fu.repeaterList'); | |||
There was a problem hiding this comment.
I thought all our events are supposed to be "past-tense"?
There was a problem hiding this comment.
Not this one - it is not triggered on this.$element and is instead used to trigger the row handler before it for accessibility.
|
Added additional issue to account for accessibility bugfix in this PR |
futuremint
added a commit
that referenced
this pull request
Oct 27, 2014
Improving Chrome focus highlighting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #726 by changing chrome's highlight on focus of rows to be more visually-appealing; also addresses minor accessibility bug #805 when attempting to select rows via enter key