This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fix checkbox markup in example page to have span #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@interactivellama the grey-ification on tabbing is back! although it's somewhat hard to see... perhaps we add the hover box-shadow effect too? (if possible) |
|
The issue is that the input has the focus and it is a child of the label. There is no CSS parent selector. The hover is able to affect the input, but the input cannot affect the label, just the span which is its sibling. |
|
@kevinparkerson @interactivellama Is this resolved and ready to be merged or on hold? |
|
@swilliamset This is a revert to a previous state that got overwritten. The hover suggestion by @kevinparkerson is not possible with CSS only due to the lack of a reverse sibling selector. TL:DR; Yes, it's good to go. |
swilliamset
pushed a commit
that referenced
this pull request
Jul 9, 2015
Fix checkbox markup in example page to have span
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
index.htmlcheckbox markup was incorrect. Fixes #1381.