Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Gray out disabled checkbox/radio while maintaining accessibility #1360

Conversation

interactivellama
Copy link
Contributor

Fixes #1380

Make disabled radio/checkbox and their labels opacity 65% instead of 50% opacity.

WCAG AA: Pass
WCAG AAA: Pass (borderline)

http://www.w3.org/WAI/WCAG1AAA-Conformance

@jamin-hall I'm getting a ratio around 7:1 which should be AAA.

@interactivellama interactivellama added this to the 3.8.1 milestone Jun 18, 2015
Make disabled radio/checkbox opacity 65%

WCAG AA: Pass
WCAG AAA: Pass (borderline)
@interactivellama interactivellama force-pushed the disabled-checkbox-radio-label-opacity branch from 0a092da to 9a343b1 Compare June 18, 2015 19:44
@interactivellama interactivellama changed the title Gray out disable while keeping accessibility Gray out disabled checkbox/radio while maintaining accessibility Jun 18, 2015
@jamin-hall
Copy link

@interactivellama let's go with 65% opacity, but we'll need to update both the "no-javascript" and "javascript" versions to be consistent. In the future we should consider AAA, but at the very least we should meet AA standards.

@kevinparkerson kevinparkerson self-assigned this Jun 30, 2015
@kevinparkerson
Copy link
Contributor

Always good to provide accessibility! The opacity change seems to be good here... on a sort-of-related note, I'm noticing in both Firefox and Chrome that tabbing does not appear to be working correctly. When I click the start of the index page and hit tab a bunch, it appears to be selecting the checkboxes as it takes quite some time to get to the checkbox example method buttons, but no indicator is shown. @interactivellama are you seeing this? I recall having some indicator upon tabbing before...

@interactivellama
Copy link
Contributor Author

#1382 fixes that issue.

@kevinparkerson
Copy link
Contributor

Cool, new issue for that. This one is good then!

kevinparkerson pushed a commit that referenced this pull request Jun 30, 2015
…o-label-opacity

Gray out disabled checkbox/radio while maintaining accessibility
@kevinparkerson kevinparkerson merged commit 728d7e9 into ExactTarget:master Jun 30, 2015
@interactivellama interactivellama modified the milestones: 3.9.1, 3.10.0 Jul 7, 2015
interactivellama added a commit to interactivellama/fuelux that referenced this pull request Jul 10, 2015
interactivellama added a commit to interactivellama/fuelux that referenced this pull request Jul 10, 2015
interactivellama added a commit to interactivellama/fuelux that referenced this pull request Jul 10, 2015
interactivellama added a commit to interactivellama/fuelux that referenced this pull request Jul 10, 2015
@interactivellama interactivellama deleted the disabled-checkbox-radio-label-opacity branch April 4, 2016 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants