Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Color consolidation into variables #1379

Merged
merged 5 commits into from
Jul 10, 2015

Conversation

interactivellama
Copy link
Contributor

Removes all hex values from LESS files. There were a few grays that had minimal saturation that were converted to hue-less grays. A few grays may have changed by 1%-3% luminance in order to create consistency. There are still 20+ grays being used.

Fixes #856 and makes getting to the idea of #972 easier although developers will still need to modify fuelux/less/variables.less if they would like to theme the controls.

@interactivellama interactivellama added this to the 3.10.0 milestone Jun 29, 2015
@interactivellama interactivellama changed the title Color consolidation Color consolidation into variables Jun 29, 2015
@interactivellama
Copy link
Contributor Author

Removed dist files and squashed!

@@ -51,10 +51,10 @@
position: relative;

&:before {
#fuelux > .icon-base-styles("Glyphicons Halflings");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch needs to be rebased/merged with the mixin namespacing solution

@interactivellama
Copy link
Contributor Author

Updated. grunt-browserify was not on the Heroku edge server.

@interactivellama
Copy link
Contributor Author

@swilliamset Updated by removing edits from other PRs that are now present since merging the past few days.

@swilliamset
Copy link
Contributor

We need to consider whether or not lighten() and desaturate() against a variable is recommended. Should the resulting values be equal to a variable already? Otherwise excepting the PR.

swilliamset pushed a commit that referenced this pull request Jul 10, 2015
@swilliamset swilliamset merged commit 5bc2cc7 into ExactTarget:master Jul 10, 2015
@interactivellama interactivellama deleted the color-consolidation branch April 4, 2016 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants