Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Ignore clicks on disabled menu items #1181

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/select.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ define(function(require) {

itemclicked: function (e) {
this.$selectedItem = $(e.target).parent();

if (this.$selectedItem.is('.disabled')) {
return;
}

this.$hiddenField.val(this.$selectedItem.attr('data-value'));
this.$label.text(this.$selectedItem.text());

Expand Down
22 changes: 21 additions & 1 deletion test/select-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,24 @@ require(['jquery', 'fuelux/select'], function ($) {
equal(selectedText, 'One', 'text passed in from changed event');
equal(selectedValue, 1, 'value passed in from changed event');
});
});

test("should not fire changed event on disabled items", function () {
var eventFired = false;
var selectedText = '';
var selectedValue = '';

var $select = $(html).select().on('changed', function (evt, data) {
eventFired = true;
selectedText = data.text;
selectedValue = data.value;
});

// Disable menu item then simulate changed event
$select.find('li:first').addClass('disabled')
.find('a').click();

equal(eventFired, false, 'changed event not fired');
equal(selectedText, '', 'text not changed');
equal(selectedValue, '', 'value not changed');
});
});