This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Ignore clicks on disabled menu items #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li.disabled class); add tests to ensure Select value doesn't change and changed event doesn't fire
|
Thanks, @jwarby. Will review. |
|
I just noticed this is targeted to the 3.6.5 milestone, but my pull request is for FuelUX 2 (as is my other outstanding pull request) - just thought I should mention... |
|
Sorry, thanks for the clarification. |
interactivellama
added a commit
that referenced
this pull request
Apr 11, 2015
Ignore clicks on disabled menu items
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Select component shouldn't allow a menu option with the 'disabled' class to be selected (see Disabled menu options).
It is easy enough to bind a click handler to Select component's DOM element to prevent this behaviour, but there is no way to achieve this for dynamically inserted Select components. Many MVC frameworks use event delegation to handle events for dynamically inserted DOM content, so there is no way to prevent this behaviour in such frameworks (at least not without breaking the framework's conventions by hacking in a workaround).
This jsfiddle might help to explain the issue a bit more clearly.