fix(combobox): ensure supporting components are auto-defined #8657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth noting that this was caught while testing #8656. 🎉 |
Merged
geospatialem
pushed a commit
that referenced
this pull request
Feb 1, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/eslint-plugin-calcite-components: 1.1.0</summary> ## [1.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.0.0...@esri/eslint-plugin-calcite-components@1.1.0) (2024-01-30) ### Features * Add `no-dynamic-createelement` rule ([#8656](#8656)) ([c7e9444](c7e9444)) </details> <details><summary>@esri/calcite-components: 2.4.0</summary> ## [2.4.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.3.0...@esri/calcite-components@2.4.0) (2024-01-30) ### Features * Add `no-dynamic-createelement` rule ([#8656](#8656)) ([c7e9444](c7e9444)) ### Bug Fixes * **chip:** Prevent rendering internal icon if not necessary. ([#8663](#8663)) ([8ca2929](8ca2929)) * **combobox:** Ensure supporting components are auto-defined ([#8657](#8657)) ([e6d792b](e6d792b)) * **list-item:** Do not focus on item cells on focusIn ([#8665](#8665)) ([ce9c9ae](ce9c9ae)) * **tile-select:** Ensure supporting components are auto-defined ([#8648](#8648)) ([2c27f40](2c27f40)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @esri/eslint-plugin-calcite-components bumped from ^1.1.0-next.0 to ^1.1.0 </details> <details><summary>@esri/calcite-components-angular: 2.4.0</summary> ## [2.4.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.3.0...@esri/calcite-components-angular@2.4.0) (2024-01-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.4.0-next.1 to ^2.4.0 </details> <details><summary>@esri/calcite-components-react: 2.4.0</summary> ## [2.4.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.3.0...@esri/calcite-components-react@2.4.0) (2024-01-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.4.0-next.1 to ^2.4.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Elijbet
pushed a commit
that referenced
this pull request
Feb 15, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/eslint-plugin-calcite-components: 1.1.0</summary> ## [1.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.0.0...@esri/eslint-plugin-calcite-components@1.1.0) (2024-01-30) ### Features * Add `no-dynamic-createelement` rule ([#8656](#8656)) ([c7e9444](c7e9444)) </details> <details><summary>@esri/calcite-components: 2.4.0</summary> ## [2.4.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.3.0...@esri/calcite-components@2.4.0) (2024-01-30) ### Features * Add `no-dynamic-createelement` rule ([#8656](#8656)) ([c7e9444](c7e9444)) ### Bug Fixes * **chip:** Prevent rendering internal icon if not necessary. ([#8663](#8663)) ([8ca2929](8ca2929)) * **combobox:** Ensure supporting components are auto-defined ([#8657](#8657)) ([e6d792b](e6d792b)) * **list-item:** Do not focus on item cells on focusIn ([#8665](#8665)) ([ce9c9ae](ce9c9ae)) * **tile-select:** Ensure supporting components are auto-defined ([#8648](#8648)) ([2c27f40](2c27f40)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @esri/eslint-plugin-calcite-components bumped from ^1.1.0-next.0 to ^1.1.0 </details> <details><summary>@esri/calcite-components-angular: 2.4.0</summary> ## [2.4.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.3.0...@esri/calcite-components-angular@2.4.0) (2024-01-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.4.0-next.1 to ^2.4.0 </details> <details><summary>@esri/calcite-components-react: 2.4.0</summary> ## [2.4.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.3.0...@esri/calcite-components-react@2.4.0) (2024-01-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.4.0-next.1 to ^2.4.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8495
Summary
This fixes an issue that prevented the Stencil build from including supporting components from being auto-defined in the components output target.
This probably wasn't noticeable since in
comboboxandcombobox-items are expected to be used together.