Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tile Select] Tile Select React components do not correctly display radio buttons / allow selection #8495

Closed
2 of 6 tasks
pllcoster opened this issue Dec 23, 2023 · 8 comments
Closed
2 of 6 tasks

[Tile Select] Tile Select React components do not correctly display radio buttons / allow selection #8495

pllcoster opened this issue Dec 23, 2023 · 8 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components-react Issues specific to the @esri/calcite-components-react package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone spike complete Issues that have a research spike completed and dev work can proceed
Milestone
2024-02-01 - Feb ...

Comments

@pllcoster
Copy link

Check existing issues

Actual Behavior

When using Calcite React components after upgrading to 2.1.0, a Tile Select component with either no type property or type="radio", no radio button appears and the tiles are not selectable.

image

Expected Behavior

Expect Radio buttons to appear as default or if type is set to "radio"

Correct functionality with calcite 1.9.1 can be seen here:
https://codesandbox.io/p/sandbox/calcite-1-9-1-tile-select-zdt9t7?file=%2Fsrc%2FApp.js%3A22%2C49

Reproduction Sample

https://codesandbox.io/p/sandbox/caclite-2-1-0-tile-select-wx4tzr?file=%2Fsrc%2FApp.js%3A22%2C49

Reproduction Steps

Create CalciteTileSelect components as described above, with type set to radio or left as default. Note that in the code sandbox checkboxes also appear to be broken.

Reproduction Version

2.1.0

Relevant Info

calcite-components-react

Regression?

Worked in 1.9

Priority impact

p2 - want for current milestone

Impact

We wish to use the tile component as a radio button in our app. With this broken we may have to swap to a different component to have a similar selection experience.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Knowledge
@pllcoster pllcoster added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Dec 23, 2023
@github-actions github-actions bot added ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone calcite-components-react Issues specific to the @esri/calcite-components-react package. labels Dec 23, 2023
@eriklharper eriklharper self-assigned this Dec 23, 2023
@eriklharper eriklharper added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Dec 23, 2023
@pllcoster
Copy link
Author

From the discussion:

Your comment pointed me in the right direction - it seems like previously we did not have to separately import @esri/calcite-components/dist/components/calcite-radio-button to have the radio button working in the tile select - but if I add this import after updating to 2.1.0, the radio buttons come back on the tile select element

@eriklharper eriklharper removed their assignment Jan 4, 2024
@eriklharper eriklharper added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 4, 2024
@geospatialem geospatialem added the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Jan 11, 2024
@geospatialem
Copy link
Member

Spike to investigate if the component could automatically import components, possibly similar to modal.

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jan 11, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 17, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 25, 2024
@jcfranco
Copy link
Member

It looks like dynamic tags passed to document.createElement prevent the Stencil build from auto-defining them. Fortunately, the fix for this is simple and is feasible for the current release.

@jcfranco jcfranco added the spike complete Issues that have a research spike completed and dev work can proceed label Jan 25, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. 2 - in development Issues that are actively being worked on. labels Jan 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@jcfranco jcfranco mentioned this issue Jan 25, 2024
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jan 25, 2024
@jcfranco jcfranco self-assigned this Jan 25, 2024
jcfranco added a commit that referenced this issue Jan 26, 2024
@jcfranco
fix(tile-select): ensure supporting components are auto-defined (#8648)
2c27f40 
**Related Issue:** #8495 

## Summary

This fixes an issue that prevented the Stencil build from including
supporting components from being auto-defined in the `components` output
target.
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 26, 2024
@eriklharper
Copy link
Contributor

Nice sleuthing on this @jcfranco ! 😉

@jcfranco jcfranco mentioned this issue Jan 26, 2024
Merged
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 26, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jan 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

jcfranco added a commit that referenced this issue Jan 26, 2024
@jcfranco
fix(combobox): ensure supporting components are auto-defined (#8657)
e6d792b 
**Related Issue:** #8495 

## Summary

This fixes an issue that prevented the Stencil build from including
supporting components from being auto-defined in the components output
target.

This probably wasn't noticeable since in `combobox` and `combobox-item`s
are expected to be used together.
@jcfranco
Copy link
Member

@DitwanP @geospatialem combobox was technically also fixed although the issue isn't likely to show up because we expect it to be used with combobox-items.

@DitwanP
Copy link
Contributor

DitwanP commented Jan 31, 2024

🍭 Verified on 2.4.0-next.1

@DitwanP DitwanP closed this as completed Jan 31, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components-react Issues specific to the @esri/calcite-components-react package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Milestone
2024-02-01 - Feb Maintenance Release
Development

No branches or pull requests
5 participants
@jcfranco @eriklharper @geospatialem @DitwanP @pllcoster