refactor(component tokens): remove old component tokens #8280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Awesome! ✨🧹✨
A couple of things I spotted:
- This should probably use
refactoras the type since removing tokens isn't a fix - There's a space between the type and the scope that needs to be removed for this to adhere to conventional commits
Other than that, this LGTM!
This was referenced Nov 28, 2023
benelan
pushed a commit
that referenced
this pull request
Dec 1, 2023
**Related Issue:** #8278 ## Summary These component tokens are out of date and should not be used. To avoid confusion and reduce the size of the repo we should remove these files.
benelan
pushed a commit
that referenced
this pull request
Dec 1, 2023
**Related Issue:** #8278 ## Summary These component tokens are out of date and should not be used. To avoid confusion and reduce the size of the repo we should remove these files.
benelan
pushed a commit
that referenced
this pull request
Dec 2, 2023
**Related Issue:** #8278 ## Summary These component tokens are out of date and should not be used. To avoid confusion and reduce the size of the repo we should remove these files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8278
Summary
These component tokens are out of date and should not be used. To avoid confusion and reduce the size of the repo we should remove these files.