Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Component Design Tokens #8278

Closed
1 of 5 tasks
alisonailea opened this issue Nov 28, 2023 · 3 comments
Closed
1 of 5 tasks

Remove unused Component Design Tokens #8278

alisonailea opened this issue Nov 28, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2023 November Pri...

Comments

@alisonailea
Copy link
Contributor

Description

There is a directory of "component" tokens in the calcite-design-tokens which are out of date and not currently in use. These should be removed.

Proposed Advantages

  • reduce the size of the calcite-design-token repo
  • reduce confusion for consumers who may think the "component" tokens should be used

Which Component

all component files in calcite-design-tokens

Relevant Info

If/when component tokens are align on in Design these can be added back on an as-needed basis.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@alisonailea alisonailea added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 28, 2023
@github-actions github-actions bot added the calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. label Nov 28, 2023
@alisonailea alisonailea mentioned this issue Nov 28, 2023
Merged
alisonailea added a commit that referenced this issue Nov 29, 2023
@alisonailea
refactor(component tokens): remove old component tokens (#8280)
7fc1513 
**Related Issue:** #8278

## Summary

These component tokens are out of date and should not be used. To avoid
confusion and reduce the size of the repo we should remove these files.
benelan pushed a commit that referenced this issue Dec 1, 2023
@alisonailea @benelan
refactor(component tokens): remove old component tokens (#8280)
f43a3ed 
**Related Issue:** #8278

## Summary

These component tokens are out of date and should not be used. To avoid
confusion and reduce the size of the repo we should remove these files.
benelan pushed a commit that referenced this issue Dec 1, 2023
@alisonailea @benelan
refactor(component tokens): remove old component tokens (#8280)
1ab5bc1 
**Related Issue:** #8278

## Summary

These component tokens are out of date and should not be used. To avoid
confusion and reduce the size of the repo we should remove these files.
benelan pushed a commit that referenced this issue Dec 2, 2023
@alisonailea @benelan
refactor(component tokens): remove old component tokens (#8280)
c70303d 
**Related Issue:** #8278

## Summary

These component tokens are out of date and should not be used. To avoid
confusion and reduce the size of the repo we should remove these files.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Installed and assigned for verification.

@jcfranco
Copy link
Member

jcfranco commented Dec 6, 2023

@alisonailea I went ahead and marked this one as installed for v2. Could you update the labels as needed?

@geospatialem geospatialem added this to the 2023 November Priorities milestone Dec 6, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed needs triage Planning workflow - pending design/dev review. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 6, 2023
@geospatialem
Copy link
Member

Verified in calcite-design-tokens in 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 November Priorities
Development

No branches or pull requests
4 participants
@jcfranco @alisonailea @geospatialem @DitwanP