Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create more specific codeowners to limit unnecessary notifications #7313

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

benelan
Copy link
Member

@benelan benelan commented Jul 12, 2023

Summary

Adds more specific codeowners to stuff that most devs don't need email notifications about. If a PR contains anything not specified in the list of globs it will still go to the calcite-components-reviewers team.

ref: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

benelan added 3 commits July 12, 2023 11:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* origin/main:
  chore: release next
  fix(block): loader now appears for all loading cases (#7303)
  build: update browserslist db (#7301)
  build(deps): Bump eslint-plugin-jsdoc from 46.2.6 to 46.4.3 (#7306)
  build(deps): Bump @floating-ui/dom from 1.4.3 to 1.4.4 in /packages/calcite-components (#7305)
  build(deps): Bump chromatic from 6.19.5 to 6.19.9 (#7308)
  build(deps): Bump cpy-cli from 4.2.0 to 5.0.0 (#7281)
  chore: release next
  feat(text-area): provide additional context for AT users when character limit exceeds (#7299)
  build(deps): Bump stylelint from 14.16.1 to 15.10.1 (#7296)
  chore: release next
  ci: allow lint-staged to find typescript parser config file (#7297)
  fix(accordion, accordion-item): `icon-position`, `icon-type`, `selection-mode` and `scale` can now be set as props or attributes (#7191)
  test(stack): stabilize screenshot tests (#7298)
  build: make sure eslint-plugin-calcite-components is set up correctly (#7294)
  chore: add translations (#7290)
  refactor: Ensure all setFocus methods return calls to setFocus (#7287)
  chore: release next
  fix(card): ensure teardown logic is called when disconnected (#7289)
  test: stabilize tests using setFocus (#7295)
@benelan benelan requested a review from a team as a code owner July 12, 2023 18:34
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jul 12, 2023
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Jul 12, 2023
@benelan benelan changed the title ci: create more specific codeowners to limit unnecessary notifications @benelan ci: create more specific codeowners to limit unnecessary notifications Jul 12, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@benelan benelan merged commit 25aff2f into main Jul 13, 2023
@benelan benelan deleted the benelan/codeowners branch July 13, 2023 06:37
@github-actions github-actions bot added this to the Design Sprint milestone Jul 13, 2023
benelan added a commit that referenced this pull request Jul 18, 2023
#7313)

## Summary
Adds more specific codeowners to stuff that most devs don't need email
notifications about. If a PR contains anything not specified in the list
of globs it will still go to the calcite-components-reviewers team.


ref:
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
benelan added a commit that referenced this pull request Jul 18, 2023
…amping-ar-numberingsystem-bug

* origin/main:
  chore(eslint): disable jsdoc/require-param-type rule in favor of typescript (#7326)
  style: lint and format code (#7319)
  chore: add editorconfig (#7318)
  chore: release next
  fix(input-date-picker): provides placeholder text context for AT users (#7320)
  chore: release next
  fix(dropdown-item): provides accessible label when href is not parsed (#7316)
  ci: create more specific codeowners to limit unnecessary notifications (#7313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants