ci: allow lint-staged to find typescript parser config file #7297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/main: (22 commits) refactor: Ensure all setFocus methods return calls to setFocus (#7287) chore: release next fix(card): ensure teardown logic is called when disconnected (#7289) test: stabilize tests using setFocus (#7295) docs: Add implementation example to `skipAnimations` util (#7293) docs: Add implementation example to `visualizeMouseCursor` util (#7292) feat: improve focus behavior in components (#7277) refactor(popover): renames private method (#7286) build(deps): Bump focus-trap from 7.4.3 to 7.5.2 (#7279) chore: release next fix(flow): Call setFocus() on back button click (#7285) chore: release next feat(flow): Adds setFocus method (#7252) chore: release next build(deps): Bump autoprefixer from 10.4.13 to 10.4.14 (#7280) build(deps): Bump eslint and @types/eslint (#7282) fix(list): fix keyboard navigation after a listItem's disabled or closed property changes (#7275) fix(action): correctly focus the button after rendering updates. (#7255) chore: release next fix(tab-title): add full focus outline to closable tab button in high contrast mode (#7272) ...
jcfranco
approved these changes
Jul 7, 2023
| @@ -918,7 +918,7 @@ async function getTagAndPage(componentTestSetup: ComponentTestSetup): Promise<Ta | |||
| * }); | |||
| * | |||
| * @param {ComponentTestSetup} componentTestSetup - A component tag, html, or the tag and e2e page for setting up a test. | |||
| * @param {DisabledOptions} [options={ focusTarget: "host" }] - Disabled options. | |||
There was a problem hiding this comment.
This looks like an autofix, but the file itself looks unrelated to these changes. Let's exclude it from this PR and then do a full lint sweep afterwards.
| @@ -1,23 +1,25 @@ | |||
| { | |||
| "env": { | |||
| module.exports = { | |||
There was a problem hiding this comment.
I was going to originally suggest keeping this as json if it didn't break anything, but this will align perfectly with the changes we'll need to make for future of configuring ESLint. 🎉
There was a problem hiding this comment.
it needs to be a cjs file so I can use __dirname
benelan
added a commit
that referenced
this pull request
Jul 12, 2023
* origin/main: chore: release next fix(block): loader now appears for all loading cases (#7303) build: update browserslist db (#7301) build(deps): Bump eslint-plugin-jsdoc from 46.2.6 to 46.4.3 (#7306) build(deps): Bump @floating-ui/dom from 1.4.3 to 1.4.4 in /packages/calcite-components (#7305) build(deps): Bump chromatic from 6.19.5 to 6.19.9 (#7308) build(deps): Bump cpy-cli from 4.2.0 to 5.0.0 (#7281) chore: release next feat(text-area): provide additional context for AT users when character limit exceeds (#7299) build(deps): Bump stylelint from 14.16.1 to 15.10.1 (#7296) chore: release next ci: allow lint-staged to find typescript parser config file (#7297) fix(accordion, accordion-item): `icon-position`, `icon-type`, `selection-mode` and `scale` can now be set as props or attributes (#7191) test(stack): stabilize screenshot tests (#7298) build: make sure eslint-plugin-calcite-components is set up correctly (#7294) chore: add translations (#7290) refactor: Ensure all setFocus methods return calls to setFocus (#7287) chore: release next fix(card): ensure teardown logic is called when disconnected (#7289) test: stabilize tests using setFocus (#7295)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
lint-stagedcorrectly fails now when there are eslint errors inpackages/calcite-components.