Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(switch)!: Remove deprecated property and event payload. #5921

Merged
merged 2 commits into from
Dec 8, 2022
Merged

refactor(switch)!: Remove deprecated property and event payload. #5921

merged 2 commits into from
Dec 8, 2022

Conversation

driskull
Copy link
Member

@driskull driskull commented Dec 6, 2022

BREAKING CHANGE: Removed deprecated switched property and calciteSwitchChange event payload.

  • Removed the property switched, use checked instead.
  • Removed the event.detail from calciteSwitchChange, use event.target.checked instead.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 6, 2022
@driskull driskull marked this pull request as ready for review December 6, 2022 22:04
@driskull driskull requested a review from a team as a code owner December 6, 2022 22:04
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 6, 2022
@geospatialem geospatialem mentioned this pull request Dec 7, 2022
Closed
benelan
benelan approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driskull driskull merged commit 4ace1d3 into master Dec 8, 2022
@driskull driskull deleted the dris0000/switch-deprecations branch December 8, 2022 16:59
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 8, 2022
benelan added a commit that referenced this pull request Dec 8, 2022
@benelan
Merge branch 'benelan/input-remove-deprecated' of github.com:Esri/cal…
e6047e6 
…cite-components into benelan/input-remove-deprecated

* 'benelan/input-remove-deprecated' of github.com:Esri/calcite-components:
  docs(changelog): fix breaking change indent levels (#5949)
  1.0.0-next.662
  refactor(handle)!: Remove deprecated event payload property on `calciteHandleNudge`. (#5935)
  refactor(tabs, tab-nav, tab-title, tab)!: Remove deprecated properties and values. (#5922)
  refactor(switch)!: Remove deprecated property and event payload. (#5921)
  docs(action): update indicator prop context for assistive technology (#5938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

Assignees

@driskull driskull

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @benelan