Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: CalciteSwitch - modify calciteSwitchChange event payload before 1.0 release #3163

Closed
driskull opened this issue Oct 6, 2021 · 2 comments
Closed

Refactor: CalciteSwitch - modify calciteSwitchChange event payload before 1.0 release #3163

driskull opened this issue Oct 6, 2021 · 2 comments
Assignees
@driskull
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. estimate - 2 Small fix or update, may require updates to tests. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2023 January Prio...

Comments

@driskull
Copy link
Member

driskull commented Oct 6, 2021

We should modify modify calciteSwitchChange event payload to not emit redundant props before 1.0 release.

As part of #3162, we deprecated the switched property in favor of checked but the event payload still has a switched property on it.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 6, 2021
@driskull driskull added the 0 - new New issues that need assignment. label Nov 8, 2021
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Nov 9, 2021
@jcfranco jcfranco mentioned this issue Dec 23, 2021
Closed
@benelan benelan added the needs triage Planning workflow - pending design/dev review. label Feb 16, 2022
@jcfranco jcfranco mentioned this issue Apr 21, 2022
Closed
@jcfranco jcfranco mentioned this issue Jul 28, 2022
Closed
@jcfranco jcfranco added this to the Sprint 07/25 - 08/05 milestone Jul 28, 2022
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 28, 2022
@jcfranco jcfranco self-assigned this Jul 28, 2022
@jcfranco jcfranco added the refactor Issues tied to code that needs to be significantly reworked. label Jul 28, 2022
@github-actions github-actions bot removed this from the Sprint 2022/10/24 - 2022/11/04 milestone Nov 7, 2022
@geospatialem geospatialem added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Nov 14, 2022
@jcfranco jcfranco added 0 - new New issues that need assignment. and removed 2 - in development Issues that are actively being worked on. labels Nov 20, 2022
@jcfranco jcfranco removed their assignment Nov 20, 2022
@Elijbet Elijbet added the estimate - 2 Small fix or update, may require updates to tests. label Dec 2, 2022
@Elijbet Elijbet self-assigned this Dec 2, 2022
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 7, 2022
@geospatialem geospatialem assigned driskull and unassigned Elijbet Dec 7, 2022
@geospatialem
Copy link
Member

geospatialem commented Dec 7, 2022 •
edited
Loading

calciteSwitchChange event payload has been modified to event.target.checked via #5921. Closing in favor of the deprecation epic #5798

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 2 - in development Issues that are actively being worked on. labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@driskull driskull

Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. estimate - 2 Small fix or update, may require updates to tests. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
5 participants
@jcfranco @driskull @geospatialem @benelan @Elijbet