feat(pagination): add built-in translations #5432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essarily map to supported ones
src/utils/locale.ts
Outdated
| "ko", | ||
| "lt", | ||
| "lv", | ||
| "nb", |
There was a problem hiding this comment.
shouldn't this be no ?
| @@ -155,15 +207,20 @@ export function getSupportedLocale(locale: string): string { | |||
| return "no"; | |||
There was a problem hiding this comment.
we may need to move this block above the .includes check to make sure if the user parses nb we return no or we replace nb with no as t9nLocales array.
…o jcfranco/4961-add-built-in-localization-for-pagination
d47cb2d
into
anveshmekala/4961-add-built-in-pseudo-translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4961
Summary
Wires up translations to the pagination component.