Skip to content

Commit

Permalink
feat(pagination): add built-in translations (#5432)
Browse files Browse the repository at this point in the history
* feat(pagination): add built-in translations

* simplify string keys to match others

* add deprecation note

* introduce context for locale lookup as translation locales do not necessarily map to supported ones

* standardize Norwegian language code

Co-authored-by: Anveshreddy mekala <anv11827@esri.com>
  • Loading branch information
jcfranco and anveshmekala authored Oct 19, 2022
1 parent ffe5f83 commit d47cb2d
Show file tree
Hide file tree
Showing 45 changed files with 175 additions and 119 deletions.
4 changes: 2 additions & 2 deletions src/components/pagination/assets/pagination/t9n/messages.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Next",
"previousLabel": "Previous"
"next": "Next",
"previous": "Previous"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "بيت_Next_________لاحقة",
"previousLabel": "بيت_Previous_________________لاحقة"
"next": "بيت_Next_________لاحقة",
"previous": "بيت_Previous_________________لاحقة"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "й_Next_________й",
"previousLabel": "й_Previous_________________й"
"next": "й_Next_________й",
"previous": "й_Previous_________________й"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Č_Next_________ž",
"previousLabel": "Č_Previous_________________ž"
"next": "Č_Next_________ž",
"previous": "Č_Previous_________________ž"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ó_Next_________à",
"previousLabel": "ó_Previous_________________à"
"next": "ó_Next_________à",
"previous": "ó_Previous_________________à"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Ř_Next_________ů",
"previousLabel": "Ř_Previous_________________ů"
"next": "Ř_Next_________ů",
"previous": "Ř_Previous_________________ů"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ø_Next_________å",
"previousLabel": "ø_Previous_________________å"
"next": "ø_Next_________å",
"previous": "ø_Previous_________________å"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ä_Next_________Ü",
"previousLabel": "ä_Previous_________________Ü"
"next": "ä_Next_________Ü",
"previous": "ä_Previous_________________Ü"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Đ_Next_________ớ",
"previousLabel": "Đ_Previous_________________ớ"
"next": "Đ_Next_________ớ",
"previous": "Đ_Previous_________________ớ"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Next",
"previousLabel": "Previous"
"next": "Next",
"previous": "Previous"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "á_Next_________Ó",
"previousLabel": "á_Previous_________________Ó"
"next": "á_Next_________Ó",
"previous": "á_Previous_________________Ó"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Š_Next_________ä",
"previousLabel": "Š_Previous_________________ä"
"next": "Š_Next_________ä",
"previous": "Š_Previous_________________ä"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Å_Next_________ö",
"previousLabel": "Å_Previous_________________ö"
"next": "Å_Next_________ö",
"previous": "Å_Previous_________________ö"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "æ_Next_________Â",
"previousLabel": "æ_Previous_________________Â"
"next": "æ_Next_________Â",
"previous": "æ_Previous_________________Â"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "כן_Next_________ש",
"previousLabel": "כן_Previous_________________ש"
"next": "כן_Next_________ש",
"previous": "כן_Previous_________________ש"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Č_Next_________ž",
"previousLabel": "Č_Previous_________________ž"
"next": "Č_Next_________ž",
"previous": "Č_Previous_________________ž"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "í_Next_________ő",
"previousLabel": "í_Previous_________________ő"
"next": "í_Next_________ő",
"previous": "í_Previous_________________ő"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ng_Next_________ny",
"previousLabel": "ng_Previous_________________ny"
"next": "ng_Next_________ny",
"previous": "ng_Previous_________________ny"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "é_Next_________È",
"previousLabel": "é_Previous_________________È"
"next": "é_Next_________È",
"previous": "é_Previous_________________È"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "須_Next_________鷗",
"previousLabel": "須_Previous_________________鷗"
"next": "須_Next_________鷗",
"previous": "須_Previous_________________鷗"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "한_Next_________빠",
"previousLabel": "한_Previous_________________빠"
"next": "한_Next_________빠",
"previous": "한_Previous_________________빠"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Į_Next_________š",
"previousLabel": "Į_Previous_________________š"
"next": "Į_Next_________š",
"previous": "Į_Previous_________________š"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ķ_Next_________ū",
"previousLabel": "ķ_Previous_________________ū"
"next": "ķ_Next_________ū",
"previous": "ķ_Previous_________________ū"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "IJ_Next_________ä",
"previousLabel": "IJ_Previous_________________ä"
"next": "IJ_Next_________ä",
"previous": "IJ_Previous_________________ä"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "å_Next_________ø",
"previousLabel": "å_Previous_________________ø"
"next": "å_Next_________ø",
"previous": "å_Previous_________________ø"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ł_Next_________ą",
"previousLabel": "ł_Previous_________________ą"
"next": "ł_Next_________ą",
"previous": "ł_Previous_________________ą"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ã_Next_________Ç",
"previousLabel": "ã_Previous_________________Ç"
"next": "ã_Next_________Ç",
"previous": "ã_Previous_________________Ç"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ã_Next_________Ç",
"previousLabel": "ã_Previous_________________Ç"
"next": "ã_Next_________Ç",
"previous": "ã_Previous_________________Ç"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Ă_Next_________ș",
"previousLabel": "Ă_Previous_________________ș"
"next": "Ă_Next_________ș",
"previous": "Ă_Previous_________________ș"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Ж_Next_________Я",
"previousLabel": "Ж_Previous_________________Я"
"next": "Ж_Next_________Я",
"previous": "Ж_Previous_________________Я"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ĺ_Next_________ľ",
"previousLabel": "ĺ_Previous_________________ľ"
"next": "ĺ_Next_________ľ",
"previous": "ĺ_Previous_________________ľ"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Š_Next_________č",
"previousLabel": "Š_Previous_________________č"
"next": "Š_Next_________č",
"previous": "Š_Previous_________________č"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Č_Next_________ž",
"previousLabel": "Č_Previous_________________ž"
"next": "Č_Next_________ž",
"previous": "Č_Previous_________________ž"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Å_Next_________ö",
"previousLabel": "Å_Previous_________________ö"
"next": "Å_Next_________ö",
"previous": "Å_Previous_________________ö"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ก้_Next_________ษฺ",
"previousLabel": "ก้_Previous_________________ษฺ"
"next": "ก้_Next_________ษฺ",
"previous": "ก้_Previous_________________ษฺ"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ı_Next_________İ",
"previousLabel": "ı_Previous_________________İ"
"next": "ı_Next_________İ",
"previous": "ı_Previous_________________İ"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "ґ_Next_________Ї",
"previousLabel": "ґ_Previous_________________Ї"
"next": "ґ_Next_________Ї",
"previous": "ґ_Previous_________________Ї"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "Đ_Next_________ớ",
"previousLabel": "Đ_Previous_________________ớ"
"next": "Đ_Next_________ớ",
"previous": "Đ_Previous_________________ớ"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "试_Next_________验",
"previousLabel": "试_Previous_________________验"
"next": "试_Next_________验",
"previous": "试_Previous_________________验"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "試_Next_________驗",
"previousLabel": "試_Previous_________________驗"
"next": "試_Next_________驗",
"previous": "試_Previous_________________驗"
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"nextLabel": "試_Next_________驗",
"previousLabel": "試_Previous_________________驗"
"next": "試_Next_________驗",
"previous": "試_Previous_________________驗"
}
5 changes: 4 additions & 1 deletion src/components/pagination/pagination.e2e.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
import { newE2EPage, E2EElement, E2EPage } from "@stencil/core/testing";
import { accessible, hidden, renders } from "../../tests/commonTests";
import { accessible, hidden, renders, t9n } from "../../tests/commonTests";
import { CSS } from "./resources";
import { html } from "../../../support/formatting";

describe("calcite-pagination", () => {
it("renders", async () => renders("calcite-pagination", { display: "flex" }));

it("honors hidden attribute", async () => hidden("calcite-pagination"));

it("is accessible", async () => accessible(`<calcite-pagination></calcite-pagination>`));

it("supports translations", () => t9n("calcite-pagination"));

describe("page links", () => {
it("should render only one page when total is less than num", async () => {
const page = await newE2EPage();
Expand Down
Loading

0 comments on commit d47cb2d

Please sign in to comment.